Support proper capsule.jvm.args parsing #106
Conversation
By forcing unix format in jimfs. Not all tests pass on Windows, but some do, now. Change-Id: If55e477411dd80b690d450621d9731240e3b6169
Capsule now parses capsule.jvm.args as command line arguments. It escapes quoted, double quoted parameters, and characters escaped by \ Change-Id: Ic1de246df1f4ba1a6de0017ebc06055638e55485
| import java.util.LinkedHashMap; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.*; |
There was a problem hiding this comment.
Oupsie, didn't see that. Should I fix it?
|
OK, I'll do that. In the meantime, I realized I left the company git script that adds a ChangeId to all commit messages (for gerrit). Do you prefer me to add commits with this change id, of rebase the whole chain? |
And make testCapsuleJvmArgsParsing a bit more readable
|
Cool, thanks! Does it work on Windows? Do you have any reason to suspect why it might not? |
|
You're right, using \ as an escape char is not a good idea on windows... I'm working on it. I might revert this whole addition to ant's cmd line parser, if I don't find a simple clever idea. |
Because it's a bad idea to consider '\' as an escaping char on windows.
|
Unless you have additional comment, I'm considering it done.... and if you agree, I'm gonna need a 1.0.3 release ;) |
|
Just quickly tested our product with capsule 1.0.3-SNAPSHOT, and it works fine for me. When are you planning a 1.0.3 release? |
|
Next week. |
|
Thanks a lot. Looking forward to it |
|
Released. |
This is trivial implementation. It does not support [escaped spaces][1]. [1]: puniverse/capsule#106
Capsule now parses capsule.jvm.args as command line arguments.
It escapes quoted, double quoted parameters,
and characters escaped by \