Pipe found list files to single cmake-format call #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes running with arg `--check` Using `\;` invokes multiple calls to cmake-format with each file as an arguments, while `+` pipes all files into the arguments. * With `\;`: ```bash cmake-format $* ./test/CMakeLists.txt cmake-format $* ./CMakeLists.txt cmake-format $* ./CMakeModules/FindSDL2.cmake cmake-format $* ./CMakeModules/Findspdlog.cmake cmake-format $* ./CMakeModules/vcpkg_android.cmake cmake-format $* ./src/CMakeLists.txt ``` exit codes of cmake-format are disposed of * With `+`: ```bash cmake-format $* ./test/CMakeLists.txt ./CMakeLists.txt ./CMakeModules/FindSDL2.cmake ./CMakeModules/Findspdlog.cmake ./CMakeModules/vcpkg_android.cmake ./src/CMakeLists.txt ``` exit code is maintained
This was referenced Jun 26, 2022
|
Nice catch! Thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes running with arg
--checkand other reasons why cmake-format would fail such as with a bad config.Using
\;invokes multiple calls to cmake-format with each file as an arguments, while+pipes all files into the arguments.\;:exit codes of cmake-format are disposed of
+:cmake-format $* ./test/CMakeLists.txt ./CMakeLists.txt ./CMakeModules/FindSDL2.cmake ./CMakeModules/Findspdlog.cmake ./CMakeModules/vcpkg_android.cmake ./src/CMakeLists.txtexit code is maintained