Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the URL of the git repo #1203

Merged
merged 4 commits into from
Sep 27, 2016
Merged

Update the URL of the git repo #1203

merged 4 commits into from
Sep 27, 2016

Conversation

larjona
Copy link
Collaborator

@larjona larjona commented Sep 23, 2016

No description provided.

strugee
strugee requested changes Sep 24, 2016
View reviewed changes
Copy link
Member

@strugee strugee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larjona thanks for preparing this! Can you also get the references in CHANGELOG.md, public/template.xss-error.jade and public/template/javascript-disabled.jade?

@larjona
Copy link
Collaborator Author

larjona commented Sep 24, 2016

The jade files, yes.
The changelog, I was not sure if it's ok to change "past references". Can you confirm?

El 24 de septiembre de 2016 07:32:27 CEST, Alex Jordan [email protected] escribió:

strugee requested changes on this pull request.

@larjona thanks for preparing this! Can you also get the references in
CHANGELOG.md, public/template.xss-error.jade and
public/template/javascript-disabled.jade?

Laura Arjona Reina
https://wiki.debian.org/LauraArjona

@strugee
Copy link
Member

strugee commented Sep 24, 2016

@larjona sure, go ahead. Change logs can be improved :)

@larjona
Copy link
Collaborator Author

larjona commented Sep 26, 2016

I think it's ready now.

strugee
strugee approved these changes Sep 27, 2016
View reviewed changes
Copy link
Member

@strugee strugee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks! Merging.

@strugee strugee merged commit 5dc3f5a into pump-io:master Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strugee strugee strugee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larjona @strugee