Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch 'Error in reactor loop escaped: mode not supported for this object: r' #2477

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

MSP-Greg
Copy link
Member

@MSP-Greg MSP-Greg commented Nov 2, 2020

Description

The following error happens intermittently in non MRI CI:

Error in reactor loop escaped: mode not supported for this object: r (ArgumentError)

PR adds a rescue in `Reactor#register.

Note that #2432 also attempted to catch this (without a rescue), but some errors still occur. I tried to remove it, and doing so caused more intermittent errors...

Updated HISTORY.md

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] or [ci skip] to the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@nateberkopec
Copy link
Member

I think you're gonna wanna avoid doing so many changes to History.md on your PRs, gonna make them impossible to merge.

Otherwise LGTM, merge it yourself I think.

@nateberkopec nateberkopec added the waiting-for-changes Waiting on changes from the requestor label Nov 10, 2020
…ect: r'

The following error happens intermittently in non MRI CI:

Error in reactor loop escaped: mode not supported for this object: r (ArgumentError)

Add rescue in `Reactor#register
@MSP-Greg MSP-Greg merged commit ae01730 into puma:master Nov 16, 2020
@MSP-Greg MSP-Greg deleted the r branch November 17, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug jruby waiting-for-changes Waiting on changes from the requestor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants