Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support to archive repositories #226

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Conversation

dirien
Copy link
Contributor

@dirien dirien commented Sep 28, 2024

This PR add support to archive a provider.

👀 @ringods @tmeckel

@dirien
Copy link
Contributor Author

dirien commented Sep 28, 2024

Not sure why both jobs are failing. 🤔

@tmeckel
Copy link
Member

tmeckel commented Sep 28, 2024

Not sure why both jobs are failing. 🤔

@dirien it's because you want to merge a branch from a fork. The repo is still not configured in a way that secrets are passed to workflow runs that started from a fork. This is an outstanding issue that @ringods and I worked upon but never came to a satisfiable solution.

@tmeckel tmeckel self-assigned this Sep 28, 2024
@dirien dirien closed this Sep 28, 2024
@dirien dirien reopened this Sep 28, 2024
@dirien
Copy link
Contributor Author

dirien commented Sep 28, 2024

@tmeckel: I have no permission to create a branch in this repo.

@tmeckel
Copy link
Member

tmeckel commented Sep 28, 2024

@dirien no need to close the PR. I'll review and merge when I've time. Sorry if my initial answer was misunderstandable in that way.

@dirien
Copy link
Contributor Author

dirien commented Sep 28, 2024

@tmeckel sounds good! Thanks!

@tmeckel tmeckel self-requested a review September 28, 2024 21:47
Copy link
Member

@tmeckel tmeckel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dirien I would set hasIssues to false, if a repository is archived hasIssues: args.archived === true ? false : true. Because it makes no sense to enable issues on an archived repository.

Same with vulnerabilityAlerts: vulnerabilityAlerts: args.archived === true ? false : true,

src/github/repositories.ts Outdated Show resolved Hide resolved
src/github/repositories.ts Outdated Show resolved Hide resolved
src/github/repositories.ts Outdated Show resolved Hide resolved
@tmeckel tmeckel added the enhancement New feature or request label Sep 28, 2024
@dirien
Copy link
Contributor Author

dirien commented Sep 28, 2024

@tmeckel done

@tmeckel
Copy link
Member

tmeckel commented Sep 29, 2024

Approved, after running pulumi preview locally with the following result

image

@tmeckel tmeckel merged commit d328763 into pulumiverse:main Sep 29, 2024
1 check failed
@dirien dirien deleted the archived branch October 1, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants