Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get upstream org from goMod object #233

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

guineveresaenger
Copy link
Contributor

@guineveresaenger guineveresaenger commented Jan 8, 2024

We were reading the upstream org from a place where we didn't set it.

@guineveresaenger guineveresaenger requested review from a team and dirien January 8, 2024 17:57
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see how this got through code review :(. Let's make sure that the following refactor includes a test that pins the correct behavior here!

@iwahbe
Copy link
Member

iwahbe commented Jan 8, 2024

Can we remove the fixes for #231, since it doesn't actually make the error message better (and we should still do that).

@guineveresaenger
Copy link
Contributor Author

oh, sorry - yeah; I thought 231 was a bug issue. Removed!

@guineveresaenger guineveresaenger merged commit 1af2257 into main Jan 8, 2024
2 checks passed
@guineveresaenger guineveresaenger deleted the guin/refactor-upstream-org branch January 8, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants