Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade-provider swallows errors from make upstream #168

Open
Tracked by #143
thomas11 opened this issue Sep 29, 2023 · 0 comments
Open
Tracked by #143

upgrade-provider swallows errors from make upstream #168

thomas11 opened this issue Sep 29, 2023 · 0 comments
Labels
kind/bug Some behavior is incorrect or out of spec

Comments

@thomas11
Copy link
Contributor

> upgrade-provider pulumi/pulumi-azure --kind=all
[...]
Applied patch to 'internal/services/web/function_app_slot_resource.go' cleanly.
U internal/services/firewall/firewall_policy_resource.go
Recorded preimage for 'internal/services/firewall/firewall_policy_resource.go'
make: *** [upstream] Error 1

Whereas

> sh ./scripts/upstream.sh upstream apply
Applied patch to 'internal/services/web/function_app_slot_resource.go' cleanly.
U internal/services/firewall/firewall_policy_resource.go
Recorded preimage for 'internal/services/firewall/firewall_policy_resource.go'

make "upstream"' failed to apply a patch. This is because there is a conflict between
the checked out version of upstream and the patch set. To resolve this conflict
run:

    FROM=$LAST_KNOWN_GOOD_COMMIT make upstream.rebase

This will walk you through resolving the conflict and producing a patch set that
cleanly applies to the current upstream.
@thomas11 thomas11 added the kind/bug Some behavior is incorrect or out of spec label Sep 29, 2023
danielrbradley added a commit that referenced this issue Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

1 participant