Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow protected resources to be replaced #8810

Merged
merged 6 commits into from
Jan 21, 2022
Merged

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Jan 21, 2022

Description

If a resource is protected we will no longer try to create a replacement for it. Previously the engine would of tried to create the replacement then issued a delete for the protected resource and then error out, that to-be-deleted-but-protected resource would then be left in the stack state and cause every up afterwards to also error.

Related to #5749

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@Frassle Frassle requested a review from a team January 21, 2022 21:38
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 nit, otherwise LGTM. (pending tests)

@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #8810 (15cd3c1) into master (90913de) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8810      +/-   ##
==========================================
+ Coverage   59.38%   59.40%   +0.01%     
==========================================
  Files         639      639              
  Lines       98020    98051      +31     
  Branches     1386     1386              
==========================================
+ Hits        58210    58248      +38     
+ Misses      36527    36519       -8     
- Partials     3283     3284       +1     
Impacted Files Coverage Δ
pkg/resource/deploy/step_generator.go 84.21% <100.00%> (+0.14%) ⬆️
sdk/python/lib/pulumi/runtime/resource.py 44.09% <0.00%> (-1.73%) ⬇️
sdk/nodejs/automation/localWorkspace.ts 74.03% <0.00%> (-0.39%) ⬇️
sdk/python/lib/pulumi/resource.py 50.25% <0.00%> (+0.65%) ⬆️
pkg/resource/deploy/step.go 79.84% <0.00%> (+0.88%) ⬆️
...k/dotnet/Pulumi/Deployment/TaskMonitoringHelper.cs 100.00% <0.00%> (+3.70%) ⬆️
sdk/go/common/util/ciutil/github_actions.go 73.52% <0.00%> (+38.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90913de...15cd3c1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants