[sdk/nodejs] Skip re-registrations of same package+version #6387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukehoban
commented
Feb 19, 2021
| @@ -28,15 +28,14 @@ describe("runtime", () => { | |||
| describe("register", () => { | |||
| const tests = [ | |||
| { name: "wildcard version", version: undefined }, | |||
| { name: "blank version", version: "" }, | |||
There was a problem hiding this comment.
This isn't a legal value at all - it happened to throw for an unrelated reason inside sameVersion - but that wasn't really what this test was trying to test.
pgavlin
approved these changes
Feb 19, 2021
added 2 commits
February 20, 2021 09:24
It is possible for the same version of the same provider SDK to be loaded multiple times in Node.js. In this case, we might legitimately get mutliple registrations of the same resource. It should not matter which we use, so we can just skip re-registering. De-serialized resources will always be instances of classes from the first registered package.
Example layout this addresses. Registrations of resources in `package3` at the same verrsion.
`node_modules`
`@pulumi/pulumi`
`package1`
`node_modules`
`package3`
`package2`
`node_modules`
`package3`
Fixes #6258.
lukehoban
force-pushed
the
lukehoban/6258
branch
from
eee05e4 to
744c7c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for the same version of the same provider SDK to be loaded multiple times in Node.js. In this case, we might legitimately get mutliple registrations of the same resource. It should not matter which we use, so we can just skip re-registering. De-serialized resources will always be instances of classes from the first registered package.
Example layout this addresses. Registrations of resources in
package3at the same verrsion.node_modules@pulumi/pulumipackage1node_modulespackage3package2node_modulespackage3Fixes #6258.