Skip to content

Commit

Permalink
Only merge when told (#16)
Browse files Browse the repository at this point in the history
We are seeing provider's merge without review or release. I believe it
is because
`automerge` is set to `"false"`, which is truthy.

GitHub Actions don't mention a `type` field for composite action's
inputs, which makes me
afraid this is just a string. This is substantiated by
actions/runner#2238.
  • Loading branch information
iwahbe authored Oct 9, 2023
2 parents d88b3c6 + 505e393 commit bc6db05
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ runs:
env:
GH_TOKEN: ${{ env.GH_TOKEN }}
- name: Set PR to auto-merge
if: ${{ inputs.automerge }}
if: ${{ inputs.automerge == 'true' }}
# This tolerates repos that do not have auto-merge enabled. `continue-on-error: true`
# should be removed when https://github.com/pulumi/home/issues/3140 closes.
continue-on-error: true
Expand Down

0 comments on commit bc6db05

Please sign in to comment.