[WIP] Add node.js module containing Terraform interpolation functions #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jen20
added
impact/usability
lukehoban
reviewed
Nov 8, 2018
sdk/nodejs/index.ts
Outdated
| * @param path the full path | ||
| */ | ||
| export function basename(path: string): string { | ||
| return Path.win32.basename(path); |
There was a problem hiding this comment.
Why does this use win32 basename?
There was a problem hiding this comment.
I believe that is the behaviour that Terraform uses filepath.basename instead of path.basename in order to deal with Windows paths correctly. I added a test for this case to ensure it works with both types.
jen20
force-pushed
the
terraform-functions-sdk
branch
from
434b893 to
cf8022a
Compare
jen20
force-pushed
the
terraform-functions-sdk
branch
from
cadf732 to
7cdd3ca
Compare
jen20
force-pushed
the
terraform-functions-sdk
branch
from
51be5ce to
314a913
Compare
|
@ellismg, as discussed, I've tagged you for review to ensure that the build system is correct. I've not yet pulled in the package publishing script, but once the tests are passing in Travis CI, I will do so. |
jen20
force-pushed
the
terraform-functions-sdk
branch
from
eeac6d5 to
ae726f5
Compare
|
This is quite stale now - so I'll close it out for now. If/when we want to come back to it there's some great work in this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is work in progress to fix #267.
The interpolation functions in Terraform are as follows (checked off when part of this PR, or with notes beside them):
absbasenamebase64decodebase64encodebase64gzip- implemented butgzipoptions appear different so test cases do not pass 1-1base64sha256base64sha512bcryptceilchompchunklistcidrhostcidrnetmaskcidrsubnetcoalescecoalescelistcompactconcatcontainsdirnamedistinctelementfileflattenfloorformatformatlistindentindexjoinjsonencodekeyslengthlistloglowermapmaxmatchkeysmd5mergeminpathexpandpowuuidreplacersadecryptsha1sha256sha512signumslicesortsplitsubstrtimestamptimeaddtitletransposetrimspaceuppervaluesurlencodezipmapThere is a minimal set of runtime dependencies (and several more development dependencies).
Still do do: