fix: Allow aiven provider to compile without fork #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFriel
force-pushed
the
friel/allow__double__underscore
branch
from
06eb24d to
70901f5
Compare
|
Diff for pulumi-azuread with merge commit b5a519a |
|
Diff for pulumi-random with merge commit 0e3da10 |
|
Diff for pulumi-random with merge commit b5a519a |
|
Diff for pulumi-azuread with merge commit 0e3da10 |
|
Diff for pulumi-gcp with merge commit b5a519a |
|
Diff for pulumi-gcp with merge commit 0e3da10 |
|
Diff for pulumi-azure with merge commit b5a519a |
|
Diff for pulumi-azure with merge commit 0e3da10 |
iwahbe
approved these changes
Jan 26, 2023
Comment on lines
-105
to
-106
| // skip underscores and make sure the next one is capitalized. | ||
| contract.Assertf(!nextCap, "Unexpected duplicate underscore: %v", name) |
There was a problem hiding this comment.
Nit: Might be nice to have a comment explaining that we will ignore duplicate _.
Attempting to use the upstream provider directly fails due to the assert removed here. I believe this change is safe to make, despite affecting all providers, as the assert causes tfgen to panic. No provider was previously allowed to use double underscores, therefore no backwards incompatible change can be caused by this. Background: The Aiven provider has data sources such as: > - `pg_partman_bgw__dot__interval` (String) > - `pg_partman_bgw__dot__role` (String) > - `pg_stat_statements__dot__track` (String) (Copied from their changelog.) The upstream provider uses a pair of routines to map `.` to `__dot__` and vice versa, and the patch in our fork of Aiven modifies that mapping to avoid double underscores: pulumi/terraform-provider-aiven@296d9e0d By allowing the bridge to generate the name, the upstream provider can be used without requiring the fork. The casing behavior is preserved, and `__dot__` is cased exactly as `_dot_` was before.
AaronFriel
force-pushed
the
friel/allow__double__underscore
branch
from
70901f5 to
996d506
Compare
|
Diff for pulumi-random with merge commit 9974297 |
|
Diff for pulumi-azuread with merge commit 9974297 |
|
Diff for pulumi-gcp with merge commit 9974297 |
|
Diff for pulumi-azure with merge commit 9974297 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to use the upstream provider directly fails due to the assert removed here.
I believe this change is safe to make, despite affecting all providers, as the assert causes tfgen to panic. No provider was previously allowed to use double underscores, therefore no backwards incompatible change can be caused by this.
Background:
The Aiven provider has data sources such as:
The upstream provider uses a pair of routines to map
.to__dot__and vice versa, and the patch in our fork of Aiven modifies that mapping to avoid double underscores:pulumi/terraform-provider-aiven@296d9e0d
By allowing the bridge to generate the name, the upstream provider can be used without requiring the fork. The casing behavior is preserved, and
__dot__is cased exactly as_dot_was before.