Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set .Repository for un-parameterized dynamic providers #2683

Merged

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Dec 3, 2024

To be good citizens of the registry, we should set the Repository field.

Related to #2664 (comment).

@iwahbe iwahbe self-assigned this Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.45%. Comparing base (6536668) to head (4bb56fd).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2683   +/-   ##
=======================================
  Coverage   69.45%   69.45%           
=======================================
  Files         301      301           
  Lines       38626    38626           
=======================================
  Hits        26827    26827           
  Misses      10275    10275           
  Partials     1524     1524           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iwahbe iwahbe force-pushed the iwahbe/set-repository-for-unparameterized-dynamic-providers branch from 7fd6ec1 to 4bb56fd Compare December 3, 2024 09:42
@iwahbe iwahbe requested a review from a team December 5, 2024 18:05
@iwahbe iwahbe merged commit 962e821 into master Dec 6, 2024
17 checks passed
@iwahbe iwahbe deleted the iwahbe/set-repository-for-unparameterized-dynamic-providers branch December 6, 2024 10:44
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.97.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants