Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: edit rule paths #2422

Merged
merged 1 commit into from
Sep 18, 2024
Merged

fix: edit rule paths #2422

merged 1 commit into from
Sep 18, 2024

Conversation

guineveresaenger
Copy link
Contributor

Installation docs were calling edit rules without filtering for valid paths first. This PR fixes that.

@guineveresaenger guineveresaenger requested a review from a team September 17, 2024 22:39
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.65%. Comparing base (f0fee4f) to head (0cc0d02).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
pkg/tfgen/installation_docs.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2422      +/-   ##
==========================================
- Coverage   57.66%   57.65%   -0.01%     
==========================================
  Files         369      369              
  Lines       50148    50146       -2     
==========================================
- Hits        28917    28914       -3     
- Misses      19652    19653       +1     
  Partials     1579     1579              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guineveresaenger guineveresaenger merged commit cfb0bd9 into master Sep 18, 2024
11 checks passed
@guineveresaenger guineveresaenger deleted the guin/apply-edit-rules branch September 18, 2024 16:25
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.91.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants