-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Reduce pfutils in runtime usage #2076
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwahbe
changed the base branch from
master
to
iwahbe/refactor-pf-shim.Provider-interface
June 8, 2024 00:37
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2076 +/- ##
==========================================
- Coverage 62.01% 61.20% -0.81%
==========================================
Files 338 339 +1
Lines 37524 45132 +7608
==========================================
+ Hits 23270 27625 +4355
- Misses 12739 15987 +3248
- Partials 1515 1520 +5 ☔ View full report in Codecov by Sentry. |
VenelinMartinov
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Base automatically changed from
iwahbe/refactor-pf-shim.Provider-interface
to
master
June 10, 2024 16:24
iwahbe
force-pushed
the
iwahbe/reduce-pfutils
branch
from
June 10, 2024 16:27
6ae86c0
to
3f87b8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #2075
This PR removes
pfutil
fromgithub.aaakk.us.kg/pulumi/pulumi-terraform-bridge/pf.ShimProvider
(introduced in #2075). There should be no runtime effects.