Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Reduce pfutils in runtime usage #2076

Merged
merged 6 commits into from
Jun 10, 2024
Merged

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Jun 8, 2024

Built on top of #2075

This PR removes pfutil from github.com/pulumi/pulumi-terraform-bridge/pf.ShimProvider (introduced in #2075). There should be no runtime effects.

@iwahbe iwahbe requested a review from t0yv0 June 8, 2024 00:36
@iwahbe iwahbe self-assigned this Jun 8, 2024
@iwahbe iwahbe changed the base branch from master to iwahbe/refactor-pf-shim.Provider-interface June 8, 2024 00:37
Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 30 lines in your changes missing coverage. Please review.

Project coverage is 61.20%. Comparing base (9cddce4) to head (ea3c33f).

Files Patch % Lines
pf/internal/pfutils/datasources.go 33.33% 4 Missing ⚠️
pf/internal/schemashim/provider.go 20.00% 4 Missing ⚠️
pf/tfbridge/provider_resources.go 0.00% 3 Missing ⚠️
pf/internal/pfutils/common.go 60.00% 2 Missing ⚠️
pf/internal/schemashim/datasource_map.go 0.00% 2 Missing ⚠️
pf/tfbridge/provider_datasources.go 0.00% 2 Missing ⚠️
pf/tfbridge/provider_invoke.go 0.00% 2 Missing ⚠️
pf/tfbridge/resource_state.go 0.00% 2 Missing ⚠️
pf/internal/pfutils/resources.go 87.50% 1 Missing ⚠️
pf/internal/schemashim/datasource.go 0.00% 1 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2076      +/-   ##
==========================================
- Coverage   62.01%   61.20%   -0.81%     
==========================================
  Files         338      339       +1     
  Lines       37524    45132    +7608     
==========================================
+ Hits        23270    27625    +4355     
- Misses      12739    15987    +3248     
- Partials     1515     1520       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@VenelinMartinov VenelinMartinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

pf/internal/pfutils/proposed_new_test.go Outdated Show resolved Hide resolved
pf/internal/pfutils/proposed_new_test.go Outdated Show resolved Hide resolved
Base automatically changed from iwahbe/refactor-pf-shim.Provider-interface to master June 10, 2024 16:24
@iwahbe iwahbe force-pushed the iwahbe/reduce-pfutils branch from 6ae86c0 to 3f87b8f Compare June 10, 2024 16:27
@iwahbe iwahbe merged commit ed2a84b into master Jun 10, 2024
11 checks passed
@iwahbe iwahbe deleted the iwahbe/reduce-pfutils branch June 10, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants