TestConfigureSimpleValues test is flaky

[VenelinMartinov]

What happened?

The test seems to panic intermittently: https://github.com/pulumi/pulumi-terraform-bridge/actions/runs/11579563225/attempts/1?pr=2497

Example

.

Output of pulumi about

.

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

[VenelinMartinov]

Hit this again: https://github.com/pulumi/pulumi-terraform-bridge/actions/runs/11593897156/job/32278920622?pr=2484

[VenelinMartinov]

hit this again: https://github.com/pulumi/pulumi-terraform-bridge/actions/runs/11595559369/attempts/1?pr=2536

[VenelinMartinov]

Skipped the test, no longer a p1 but we should fix it

[VenelinMartinov]

@guineveresaenger hit this again: https://github.com/pulumi/pulumi-terraform-bridge/actions/runs/11661851981/job/32466988842

[guineveresaenger]

The occasions I saw were hitting on ubuntu default, but that might just be chance

[VenelinMartinov]

Hit this again: https://github.com/pulumi/pulumi-terraform-bridge/actions/runs/11935083949/job/33265640151?pr=2639

[iwahbe]

Hit this again: https://github.com/pulumi/pulumi-terraform-bridge/actions/runs/11935083949/job/33265640151?pr=2639

The error trace is

=== NAME  TestConfigure/set-attribute/empty
    configure.go:210: 
        	Error Trace:	/home/runner/work/pulumi-terraform-bridge/pulumi-terraform-bridge/pkg/pf/tests/internal/cross-tests/configure.go:210
        	            				/home/runner/work/pulumi-terraform-bridge/pulumi-terraform-bridge/pkg/pf/tests/internal/cross-tests/configure.go:59

This is the PF configure call. The rest of the issue has been about the SDKv2 Configure call.

[VenelinMartinov]

Another TestConfigure flake: https://github.com/pulumi/pulumi-terraform-bridge/actions/runs/11972273455/job/33378845348?pr=2656

[iwahbe]

Is it the error that pulumi/pulumi#17825 is supposed to fix?

[VenelinMartinov]

No, doesn't look like it

    configure.go:210: 
        	Error Trace:	/home/runner/work/pulumi-terraform-bridge/pulumi-terraform-bridge/pkg/pf/tests/internal/cross-tests/configure.go:210
        	            				/home/runner/work/pulumi-terraform-bridge/pulumi-terraform-bridge/pkg/pf/tests/internal/cross-tests/configure.go:59
        	Error:      	Not equal: 
        	            	expected: tfsdk.Config{Raw:tftypes.Value{typ:tftypes.Object{AttributeTypes:map[string]tftypes.Type{"k":tftypes.Set{ElementType:tftypes.primitive{name:"String", _:[]struct {}(nil)}, _:[]struct {}(nil)}}, OptionalAttributes:map[string]struct {}(nil), _:[]struct {}(nil)}, value:map[string]tftypes.Value{"k":tftypes.Value{typ:tftypes.Set{ElementType:tftypes.primitive{name:"String", _:[]struct {}(nil)}, _:[]struct {}(nil)}, value:interface {}(nil)}}}, Schema:schema.Schema{Attributes:map[string]schema.Attribute{"k":schema.SetAttribute{ElementType:basetypes.StringType{}, CustomType:basetypes.SetTypable(nil), Required:false, Optional:true, Sensitive:false, Description:"", MarkdownDescription:"", DeprecationMessage:"", Validators:[]validator.Set(nil)}}, Blocks:map[string]schema.Block(nil), Description:"", MarkdownDescription:"", DeprecationMessage:""}}
        	            	actual  : tfsdk.Config{Raw:tftypes.Value{typ:tftypes.Type(nil), value:interface {}(nil)}, Schema:fwschema.Schema(nil)}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -2,48 +2,6 @@
        	            	  Raw: (tftypes.Value) {
        	            	-  typ: (tftypes.Object) {
        	            	-   AttributeTypes: (map[string]tftypes.Type) (len=1) {
        	            	-    (string) (len=1) "k": (tftypes.Set) {
        	            	-     ElementType: (tftypes.primitive) {
        	            	-      name: (string) (len=6) "String",
        	            	-      _: ([]struct {}) <nil>
        	            	-     },
        	            	-     _: ([]struct {}) <nil>
        	            	-    }
        	            	-   },
        	            	-   OptionalAttributes: (map[string]struct {}) <nil>,
        	            	-   _: ([]struct {}) <nil>
        	            	-  },
        	            	-  value: (map[string]tftypes.Value) (len=1) {
        	            	-   (string) (len=1) "k": (tftypes.Value) {
        	            	-    typ: (tftypes.Set) {
        	            	-     ElementType: (tftypes.primitive) {
        	            	-      name: (string) (len=6) "String",
        	            	-      _: ([]struct {}) <nil>
        	            	-     },
        	            	-     _: ([]struct {}) <nil>
        	            	-    },
        	            	-    value: (interface {}) <nil>
        	            	-   }
        	            	-  }
        	            	+  typ: (tftypes.Type) <nil>,
        	            	+  value: (interface {}) <nil>
        	            	  },
        	            	- Schema: (schema.Schema) {
        	            	-  Attributes: (map[string]schema.Attribute) (len=1) {
        	            	-   (string) (len=1) "k": (schema.SetAttribute) {
        	            	-    ElementType: (basetypes.StringType) {
        	            	-    },
        	            	-    CustomType: (basetypes.SetTypable) <nil>,
        	            	-    Required: (bool) false,
        	            	-    Optional: (bool) true,
        	            	-    Sensitive: (bool) false,
        	            	-    Description: (string) "",
        	            	-    MarkdownDescription: (string) "",
        	            	-    DeprecationMessage: (string) "",
        	            	-    Validators: ([]validator.Set) <nil>
        	            	-   }
        	            	-  },
        	            	-  Blocks: (map[string]schema.Block) <nil>,
        	            	-  Description: (string) "",
        	            	-  MarkdownDescription: (string) "",
        	            	-  DeprecationMessage: (string) ""
        	            	- }
        	            	+ Schema: (fwschema.Schema) <nil>
        	            	 }
        	Test:       	TestConfigure/set-attribute/missing

[iwahbe]

#2661 implements the same strategy as helped reduce TestConfigureSimpleValues flakes.