Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade terraform-provider-snowflake to v1.0.0 #777

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Dec 13, 2024

This PR was generated via $ upgrade-provider pulumi/pulumi-snowflake --major.


@iwahbe iwahbe added the needs-release/major When a PR with this label merges, it initiates a release of vX+1.0.0 label Dec 13, 2024
@iwahbe iwahbe enabled auto-merge (squash) December 13, 2024 14:01
Copy link

github-actions bot commented Dec 13, 2024

Does the PR have any schema changes?

Found 64 breaking changes:

Resources

  • "snowflake:index/account:Account":
    • 🟡 inputs: "mustChangePassword" type changed from "boolean" to "string"
    • properties:
      • 🟡 "isOrgAdmin" type changed from "boolean" to "string"
      • 🟡 "mustChangePassword" type changed from "boolean" to "string"
    • 🟢 required: "isOrgAdmin" property is no longer Required
    • 🟢 required inputs: "gracePeriodInDays" input has changed to Required
  • 🔴 "snowflake:index/databaseOld:DatabaseOld" missing
  • 🔴 "snowflake:index/function:Function" missing
  • 🔴 "snowflake:index/oauthIntegration:OauthIntegration" missing
  • 🟢 "snowflake:index/oauthIntegrationForCustomClients:OauthIntegrationForCustomClients": required: "blockedRolesLists" property is no longer Required
  • 🟢 "snowflake:index/oauthIntegrationForPartnerApplications:OauthIntegrationForPartnerApplications": required: "blockedRolesLists" property is no longer Required
  • 🔴 "snowflake:index/procedure:Procedure" missing
  • 🔴 "snowflake:index/role:Role" missing
  • 🔴 "snowflake:index/samlIntegration:SamlIntegration" missing
  • 🔴 "snowflake:index/sessionParameter:SessionParameter" missing
  • 🔴 "snowflake:index/stream:Stream" missing
  • "snowflake:index/tagAssociation:TagAssociation":
    • inputs:
      • 🟡 "objectIdentifiers": items type changed from "#/types/snowflake:index/TagAssociationObjectIdentifier:TagAssociationObjectIdentifier" to "string"
      • 🟡 "objectName" missing
    • properties:
      • 🟡 "objectIdentifiers": items type changed from "#/types/snowflake:index/TagAssociationObjectIdentifier:TagAssociationObjectIdentifier" to "string"
      • 🟡 "objectName" missing output "objectName"
  • 🔴 "snowflake:index/tagMaskingPolicyAssociation:TagMaskingPolicyAssociation" missing
  • 🔴 "snowflake:index/unsafeExecute:UnsafeExecute" missing

Functions

  • 🟡 "snowflake:index/getAccounts:getAccounts": inputs: "pattern" missing input "pattern"
  • 🔴 "snowflake:index/getRole:getRole" missing
  • 🔴 "snowflake:index/getRoles:getRoles" missing

Types

  • 🔴 "snowflake:index/DatabaseOldReplicationConfiguration:DatabaseOldReplicationConfiguration" missing
  • 🔴 "snowflake:index/FunctionArgument:FunctionArgument" missing
  • 🔴 "snowflake:index/ProcedureArgument:ProcedureArgument" missing
  • 🔴 "snowflake:index/RoleShowOutput:RoleShowOutput" missing
  • 🔴 "snowflake:index/TagAssociationObjectIdentifier:TagAssociationObjectIdentifier" missing
  • "snowflake:index/getAccountsAccount:getAccountsAccount":
    • properties:
      • 🟡 "accountLocator" missing
      • 🟡 "accountLocatorUrl" missing
      • 🟡 "accountName" missing
      • 🟡 "accountUrl" missing
      • 🟡 "comment" missing
      • 🟡 "consumptionBillingEntityName" missing
      • 🟡 "createdOn" missing
      • 🟡 "edition" missing
      • 🟡 "isOrgAdmin" missing
      • 🟡 "managedAccounts" missing
      • 🟡 "marketplaceConsumerBillingEntityName" missing
      • 🟡 "marketplaceProviderBillingEntityName" missing
      • 🟡 "oldAccountUrl" missing
      • 🟡 "organizationName" missing
      • 🟡 "regionGroup" missing
      • 🟡 "snowflakeRegion" missing
    • required:
      • 🟢 "accountLocator" property is no longer Required
      • 🟢 "accountLocatorUrl" property is no longer Required
      • 🟢 "accountName" property is no longer Required
      • 🟢 "accountUrl" property is no longer Required
      • 🟢 "comment" property is no longer Required
      • 🟢 "consumptionBillingEntityName" property is no longer Required
      • 🟢 "createdOn" property is no longer Required
      • 🟢 "edition" property is no longer Required
      • 🟢 "isOrgAdmin" property is no longer Required
      • 🟢 "managedAccounts" property is no longer Required
      • 🟢 "marketplaceConsumerBillingEntityName" property is no longer Required
      • 🟢 "marketplaceProviderBillingEntityName" property is no longer Required
      • 🟢 "oldAccountUrl" property is no longer Required
      • 🟢 "organizationName" property is no longer Required
      • 🟢 "regionGroup" property is no longer Required
      • 🟢 "showOutputs" property has changed to Required
      • 🟢 "snowflakeRegion" property is no longer Required
  • 🔴 "snowflake:index/getRolesRole:getRolesRole" missing
  • 🔴 "snowflake:index/getRolesRoleShowOutput:getRolesRoleShowOutput" missing

New resources:

  • index/execute.Execute
  • index/functionJava.FunctionJava
  • index/functionJavascript.FunctionJavascript
  • index/functionPython.FunctionPython
  • index/functionScala.FunctionScala
  • index/functionSql.FunctionSql
  • index/procedureJava.ProcedureJava
  • index/procedureJavascript.ProcedureJavascript
  • index/procedurePython.ProcedurePython
  • index/procedureScala.ProcedureScala
  • index/procedureSql.ProcedureSql

New functions:

  • index/getAccountRoles.getAccountRoles

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 76 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (6accd68) to head (93ae733).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
provider/resources.go 0.00% 76 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #777   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           3       3           
  Lines         169     174    +5     
======================================
- Misses        169     174    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iwahbe iwahbe force-pushed the upgrade-terraform-provider-snowflake-to-v1.0.0-major branch from 516ac8e to f0e5b39 Compare December 13, 2024 14:43
@guineveresaenger guineveresaenger force-pushed the upgrade-terraform-provider-snowflake-to-v1.0.0-major branch from 04d2443 to c07d4cf Compare December 16, 2024 22:50
@iwahbe iwahbe force-pushed the upgrade-terraform-provider-snowflake-to-v1.0.0-major branch from c07d4cf to 863f7c2 Compare December 17, 2024 09:05
@iwahbe iwahbe force-pushed the upgrade-terraform-provider-snowflake-to-v1.0.0-major branch from 863f7c2 to 93ae733 Compare December 17, 2024 12:47
@iwahbe iwahbe merged commit 25548ee into master Dec 17, 2024
25 checks passed
@iwahbe iwahbe deleted the upgrade-terraform-provider-snowflake-to-v1.0.0-major branch December 17, 2024 12:55
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v1.0.0.

@github-actions github-actions bot removed the needs-release/major When a PR with this label merges, it initiates a release of vX+1.0.0 label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade terraform-provider-snowflake to v1.0.0
2 participants