Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go 1.13.x in Travis #223

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Use go 1.13.x in Travis #223

merged 1 commit into from
Apr 2, 2020

Conversation

justinvp
Copy link
Member

@justinvp justinvp commented Apr 1, 2020

After publishing packages, we use our standard build-package-docs.sh script to automatically open a PR in the docs repo to update the docs.

When v0.5.0 was released, updating the docs failed with:

$(go env GOPATH)/src/github.com/pulumi/scripts/ci/build-package-docs.sh policy
...
# github.com/cbroglie/mustache
1815../../cbroglie/mustache/mustache.go:549:18: valueInd.IsZero undefined (type reflect.Value has no field or method IsZero)

https://travis-ci.com/github/pulumi/pulumi-policy/builds/157624670

It looks like using go 1.13 in Travis would avoid that error.

This should address the failure when attempting to automatically open a docs PR for releases.
@justinvp justinvp requested review from ekrengel and jkisk April 1, 2020 23:56
@justinvp justinvp added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Apr 1, 2020
@justinvp justinvp merged commit b19755f into master Apr 2, 2020
@pulumi-bot pulumi-bot deleted the justin/go branch April 2, 2020 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants