Some stack outputs cannot be saved to Secret #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EronWright
commented
Nov 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #746 +/- ##
==========================================
+ Coverage 50.70% 50.73% +0.02%
==========================================
Files 30 30
Lines 4171 4173 +2
==========================================
+ Hits 2115 2117 +2
Misses 1872 1872
Partials 184 184 ☔ View full report in Codecov by Sentry. |
blampe
approved these changes
Nov 11, 2024
EronWright
force-pushed
the
issue-743
branch
from
2fe569e to
c24cbf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR sanitizes the output names from a given
Updatewhen the outputs are stored into aSecret.Related issues (optional)
Closes #743