Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] E2E test for --target #711

Merged
merged 3 commits into from
Oct 11, 2024
Merged

[v2] E2E test for --target #711

merged 3 commits into from
Oct 11, 2024

Conversation

blampe
Copy link
Contributor

@blampe blampe commented Oct 8, 2024

Turns out we already plumb target from Stack → Update → Agent → Auto API:

Target: o.Spec.Targets,
TargetDependents: ptr.To(o.Spec.TargetDependents),

Target: obj.Spec.Target,
TargetDependents: obj.Spec.TargetDependents,

if in.Target != nil {
opts = append(opts, optup.Target(in.Target))
}
if in.GetTargetDependents() {
opts = append(opts, optup.TargetDependents())

This adds a small E2E test around the behavior.

@blampe blampe added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.57%. Comparing base (2a67d4c) to head (163573b).
Report is 2 commits behind head on v2.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2     #711   +/-   ##
=======================================
  Coverage   49.57%   49.57%           
=======================================
  Files          27       27           
  Lines        2911     2911           
=======================================
  Hits         1443     1443           
  Misses       1290     1290           
  Partials      178      178           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blampe blampe requested review from EronWright and rquitales October 8, 2024 21:18
@blampe blampe merged commit 83f8438 into v2 Oct 11, 2024
6 checks passed
@blampe blampe deleted the blampe/targets branch October 11, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants