Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Use official nonroot images for e2e tests #692

Merged
merged 2 commits into from
Sep 26, 2024
Merged

[v2] Use official nonroot images for e2e tests #692

merged 2 commits into from
Sep 26, 2024

Conversation

blampe
Copy link
Contributor

@blampe blampe commented Sep 26, 2024

Speed up e2e tests by using the official nonroot image instead of building and loading it locally.

@blampe blampe requested a review from rquitales September 26, 2024 18:27
@blampe blampe added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.11%. Comparing base (7ce746c) to head (b8e2ada).
Report is 1 commits behind head on v2.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2     #692   +/-   ##
=======================================
  Coverage   49.11%   49.11%           
=======================================
  Files          26       26           
  Lines        2877     2877           
=======================================
  Hits         1413     1413           
  Misses       1287     1287           
  Partials      177      177           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@EronWright EronWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gets us very close to resolving this issue:
#653 (comment)

@blampe blampe merged commit b912fd4 into v2 Sep 26, 2024
7 checks passed
@blampe blampe deleted the blampe/nonroot branch September 26, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants