Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ephemeral storage for disk mutations #109

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Use ephemeral storage for disk mutations #109

merged 1 commit into from
Dec 1, 2020

Conversation

viveklak
Copy link
Contributor

@viveklak viveklak commented Dec 1, 2020

Fixes #96. Prerequisite for #78 and should help with #104 as well.

Two changes here:

  1. Set the global config and cache directories to be in /tmp. The Docker image by default seemed to be using /root/.xyz which is the reason for Typescript programs using external dependencies do not run #96.
  2. We should be avoiding writing state back into the image (overlay). /tmp is now an emptyDir mount which will make the entire /tmp directory ephimeral for the lifecycle of the pod. Once the pod dies, the storage is immediately released. This would be valuable for Move the reconciliation loop to a model where each run executes as a k8s Job #78

Copy link
Contributor

@lukehoban lukehoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viveklak viveklak merged commit ca420c3 into master Dec 1, 2020
@viveklak viveklak deleted the vl/FixRootRef branch December 1, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript programs using external dependencies do not run
3 participants