Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a workspace template to the Stack #666

Closed
EronWright opened this issue Sep 16, 2024 · 3 comments
Closed

Add a workspace template to the Stack #666

EronWright opened this issue Sep 16, 2024 · 3 comments
Assignees
@EronWright
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@EronWright
Copy link
Contributor

EronWright commented Sep 16, 2024 •
edited
Loading

Add a workspaceTemplate to the Stack spec, to allow for general extensibility of the stack's workspace.

The stack controller should merge the provided template using strategic merge patch, similarly to how the workspace controller merges the pod template (ref).
@EronWright EronWright converted this from a draft issue Sep 16, 2024
@cleverguy25
Copy link

Added to epic #586

@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Sep 16, 2024
@cleverguy25 cleverguy25 mentioned this issue Sep 16, 2024
Closed
5 tasks
@EronWright EronWright removed the needs-triage Needs attention from the triage team label Sep 16, 2024
@blampe blampe mentioned this issue Sep 18, 2024
Merged
blampe added a commit that referenced this issue Sep 18, 2024
@blampe
[v2] Add workspaceTemplate to Stack API (#669)
9bc598d 
This adds a `workspaceTemplate` field to the Stack API. Also removes
`resources` and `image` from the API, since those can now be specified
via `workspaceTemplate` and it's confusing for them to be overridable in
two places. We can re-add these as a convenience later when we've
thought through precedence and validation for them.

Fixes #666
@mikhailshilkov mikhailshilkov added the kind/enhancement Improvements or new features label Sep 19, 2024
@pulumi-bot
Copy link
Contributor

Cannot close issue:

  • does not have required labels: resolution/

Please fix these problems and try again.

@pulumi-bot pulumi-bot reopened this Sep 19, 2024
@EronWright EronWright added the resolution/fixed This issue was fixed label Sep 19, 2024
@pulumi-bot
Copy link
Contributor

Cannot close issue:

  • does not have an assignee

Please fix these problems and try again.

@pulumi-bot pulumi-bot reopened this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EronWright EronWright

Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
No open projects
Pulumi Kubernetes Operator v2
Status: Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mikhailshilkov @EronWright @cleverguy25 @ericrudder @pulumi-bot