Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default "master" branch behavior #164

Closed
lblackstone opened this issue Jul 23, 2021 · 1 comment · Fixed by #168
Closed

Remove default "master" branch behavior #164

lblackstone opened this issue Jul 23, 2021 · 1 comment · Fixed by #168
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@lblackstone
Copy link
Member

I think we should change the operator to require that either a branch or commit is specified, and get rid of the default behavior of deploying the master branch. The user is already specifying other information about the git repo in the Stack CR, so it shouldn't be an undue burden to be explicit about the desired behavior. Furthermore, both the git CLI and GitHub have moved to using main as the default branch name, so using master is no longer a good default assumption.

Affected feature

Stack CustomResource will currently deploy the latest commit from the master branch if neither branch nor commit is specified.

@lblackstone lblackstone added the kind/enhancement Improvements or new features label Jul 23, 2021
@elsesiy
Copy link
Contributor

elsesiy commented Jul 26, 2021

I agree that specifying either branch or commit via the stack CR is a reasonable expectation and is how I envisioned to use the polling feature. If anything, being explicit about which revision is tracked helps debug issues and prevent misconfigurations

viveklak pushed a commit that referenced this issue Jul 29, 2021
…168)

Update docs (crd) for new behavior
Update pulumi/pulumi to 3.9.0
Update CHANGELOG
Add small util to dynamically determine os for sed invocation

Fix #164
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants