Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java 1, Adding Make Ensure, Syncing all go modules. #305

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Java 1, Adding Make Ensure, Syncing all go modules. #305

merged 1 commit into from
Jan 29, 2025

Conversation

rshade
Copy link
Contributor

@rshade rshade commented Jan 17, 2025

Java 1, Adding Make Ensure, Syncing all go modules.
Updating editorconfig so that schema.json doesn't try to reformat each time

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

Does the PR have any schema changes?

Found 30 breaking changes:

Resources

  • "kubernetes-cert-manager:index:CertManager": inputs:
    • 🟡 "affinity" type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:Affinity" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:Affinity"
    • 🟡 "containerSecurityContext" type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:SecurityContext" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:SecurityContext"
    • 🟡 "extraEnv": items type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:EnvVar" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:EnvVar"
    • 🟡 "extraVolumeMounts": items type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:VolumeMount" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:VolumeMount"
    • 🟡 "extraVolumes": items type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:Volume" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:Volume"
    • 🟡 "nodeSelector" type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:NodeSelector" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:NodeSelector"
    • 🟡 "podDnsConfig" type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:PodDNSConfig" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:PodDNSConfig"
    • 🟡 "resources" type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:ResourceRequirements" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:ResourceRequirements"
    • 🟡 "securityContext" type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:PodSecurityContext" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:PodSecurityContext"
    • 🟡 "strategy" type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:apps/v1:DeploymentStrategy" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:apps/v1:DeploymentStrategy"
    • 🟡 "tolerations": items type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:Toleration" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:Toleration"

Types

  • "kubernetes-cert-manager:index:CertManagerCaInjector": properties:
    • 🟡 "affinity" type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:Affinity" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:Affinity"
    • 🟡 "containerSecurityContext" type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:SecurityContext" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:SecurityContext"
    • 🟡 "podSecurityContext" type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:PodSecurityContext" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:PodSecurityContext"
    • 🟡 "resources" type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:ResourceRequirements" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:ResourceRequirements"
    • 🟡 "strategy" type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:apps/v1:DeploymentStrategy" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:apps/v1:DeploymentStrategy"
    • 🟡 "tolerations": items type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:Toleration" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:Toleration"
  • 🟡 "kubernetes-cert-manager:index:CertManagerGlobal": properties: "imagePullSecrets": items type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:LocalObjectReference" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:LocalObjectReference"
  • "kubernetes-cert-manager:index:CertManagerStartupAPICheck": properties:
    • 🟡 "affinity" type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:Affinity" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:Affinity"
    • 🟡 "resources" type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:ResourceRequirements" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:ResourceRequirements"
    • 🟡 "securityContext" type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:PodSecurityContext" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:PodSecurityContext"
    • 🟡 "tolerations": items type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:Toleration" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:Toleration"
  • "kubernetes-cert-manager:index:CertManagerWebhook": properties:
    • 🟡 "affinity" type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:Affinity" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:Affinity"
    • 🟡 "containerSecurityContext" type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:SecurityContext" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:SecurityContext"
    • 🟡 "livenessProbe" type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:Probe" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:Probe"
    • 🟡 "readinessProbe" type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:Probe" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:Probe"
    • 🟡 "resources" type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:ResourceRequirements" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:ResourceRequirements"
    • 🟡 "securityContext" type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:PodSecurityContext" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:PodSecurityContext"
    • 🟡 "strategy" type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:apps/v1:DeploymentStrategy" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:apps/v1:DeploymentStrategy"
    • 🟡 "tolerations": items type changed from "/kubernetes/v4.19.0/schema.json#/types/kubernetes:core/v1:Toleration" to "/kubernetes/v4.21.0/schema.json#/types/kubernetes:core/v1:Toleration"
      No new resources/functions.

@rshade rshade requested a review from a team January 17, 2025 19:36
@rshade rshade force-pushed the update-java_1 branch 4 times, most recently from 2d59472 to d4ce989 Compare January 23, 2025 14:25
@rshade
Java 1, Adding Make Ensure, Syncing all go modules.
c5fc06a 
Updating editorconfig so that schema.json doesn't try to reformat each time
@rshade rshade merged commit 3ed0da8 into master Jan 29, 2025
17 checks passed
@rshade rshade deleted the update-java_1 branch January 29, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EronWright EronWright EronWright approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rshade @EronWright