-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade pulumi sdk packages #282
Conversation
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sklarsa. Thanks for opening a PR.
This library supports all currently supported go versions (1.22 & 1.23). I'd be happy to take the version bump on github.com/pulumi/pulumi/{pkg,sdk}/v3
, we will defer updating the Go version until Go 1.24 comes out.
This reverts commit bf3ab14.
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
Makes sense, just bumped the 2 pulumi deps |
@sklarsa See the test failures: looks like a |
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
==========================================
- Coverage 69.19% 69.17% -0.02%
==========================================
Files 37 37
Lines 5109 5109
==========================================
- Hits 3535 3534 -1
Misses 1306 1306
- Partials 268 269 +1 ☔ View full report in Codecov by Sentry. |
handled here: 0133e90 |
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
Ah I need to rerun the EDIT: nevermind, I just merged and ran go mod tidy again for each subdir |
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating here!
This PR has been shipped in release v0.24.0. |
I'm developing a project that is using go 1.23.3 and
github.com/pulumi/pulumi/sdk/v3 v3.142.0
. When trying to compile a provider binary using the same module, I get compilation errors: