Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pulumi sdk packages #282

Merged
merged 6 commits into from
Dec 13, 2024
Merged

Upgrade pulumi sdk packages #282

merged 6 commits into from
Dec 13, 2024

Conversation

sklarsa
Copy link
Contributor

@sklarsa sklarsa commented Dec 11, 2024

I'm developing a project that is using go 1.23.3 and github.com/pulumi/pulumi/sdk/v3 v3.142.0. When trying to compile a provider binary using the same module, I get compilation errors:

# github.com/pulumi/pulumi/pkg/v3/workspace
../../../go/pkg/mod/github.com/pulumi/pulumi/pkg/[email protected]/workspace/plugin.go:65:29: not enough arguments in call to pluginSpec.GetLatestVersion
	have ()
	want ("context".Context)
../../../go/pkg/mod/github.com/pulumi/pulumi/pkg/[email protected]/workspace/plugin.go:83:71: not enough arguments in call to workspace.DownloadToFile
	have ("github.com/pulumi/pulumi/sdk/v3/go/common/workspace".PluginSpec, func(stream "io".ReadCloser, size int64) "io".ReadCloser, func(err error, attempt int, limit int, delay time.Duration))
	want ("context".Context, "github.com/pulumi/pulumi/sdk/v3/go/common/workspace".PluginSpec, func(stream "io".ReadCloser, size int64) "io".ReadCloser, func(err error, attempt int, limit int, delay time.Duration))

Copy link

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

  • /run-acceptance-tests - used to test run the acceptance tests for the project

@iwahbe iwahbe self-requested a review December 11, 2024 10:54
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sklarsa. Thanks for opening a PR.

This library supports all currently supported go versions (1.22 & 1.23). I'd be happy to take the version bump on github.com/pulumi/pulumi/{pkg,sdk}/v3, we will defer updating the Go version until Go 1.24 comes out.

Copy link

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

  • /run-acceptance-tests - used to test run the acceptance tests for the project

@sklarsa
Copy link
Contributor Author

sklarsa commented Dec 11, 2024

Makes sense, just bumped the 2 pulumi deps

@sklarsa sklarsa requested a review from iwahbe December 11, 2024 14:50
@mjeffryes
Copy link
Member

@sklarsa See the test failures: looks like a go mod tidy is still required

Copy link

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

  • /run-acceptance-tests - used to test run the acceptance tests for the project

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.17%. Comparing base (0133e90) to head (57c7750).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #282      +/-   ##
==========================================
- Coverage   69.19%   69.17%   -0.02%     
==========================================
  Files          37       37              
  Lines        5109     5109              
==========================================
- Hits         3535     3534       -1     
  Misses       1306     1306              
- Partials      268      269       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sklarsa sklarsa changed the title Update go module to 1.23 Upgrade pulumi sdk packages Dec 12, 2024
@sklarsa
Copy link
Contributor Author

sklarsa commented Dec 13, 2024

handled here: 0133e90

@sklarsa sklarsa closed this Dec 13, 2024
@sklarsa sklarsa reopened this Dec 13, 2024
Copy link

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

  • /run-acceptance-tests - used to test run the acceptance tests for the project

@sklarsa
Copy link
Contributor Author

sklarsa commented Dec 13, 2024

Ah I need to rerun the go mod tidy. Can dependabot do this for me

EDIT: nevermind, I just merged and ran go mod tidy again for each subdir

Copy link

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

  • /run-acceptance-tests - used to test run the acceptance tests for the project

Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating here!

@iwahbe iwahbe merged commit 5943837 into pulumi:main Dec 13, 2024
8 checks passed
@pulumi-bot
Copy link

This PR has been shipped in release v0.24.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants