Enforce labels secretness #1317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appreciate your work looking into this, thank you! Let's design a plan for the bridge here. :) |
|
Blocked on pulumi/pulumi-terraform-bridge#1506. |
Base automatically changed from
upgrade-terraform-provider-google-beta-to-v5.0.0
to
master
November 9, 2023 19:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1316
This is a WIP PR. The code should be complete, but there are not any tests.
Update:
The bridge is not currently set up to accept secrets from the engine:
https://github.com/pulumi/pulumi-terraform-bridge/blob/218029989c4c3e1086b576dada10f77ccff30cf9/pkg/tfbridge/provider.go#L537-L539
https://github.com/pulumi/pulumi-terraform-bridge/blob/218029989c4c3e1086b576dada10f77ccff30cf9/pf/internal/plugin/provider_server.go#L274-L279
The code in this PR propagates secrets, but it never receives secrets to propagate. Enforcing this will require allowing the bridge to accept secrets. Doing so safely is a large project.