Remove cluster provider from schema #746
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. |
|
I believe we also want to nuke it from the schema which should drop it from the sdk at the least: https://github.com/pulumi/pulumi-eks/blob/master/provider/cmd/pulumi-gen-eks/main.go#L164-L166 |
This reverts commit 51bdee8.
jaxxstorm
changed the title
|
@viveklak I actually think nuking it from the schema is a better way, so I went ahead and did that |
Does the PR have any schema changes?Found 1 breaking change: |
|
This is only a break in non-TS providers |
| @@ -1,5 +1,6 @@ | |||
| ## Unreleased | |||
| (None) | |||
| - Remove cluster provider from schema | |||
There was a problem hiding this comment.
Maybe we need a bit more explanation for the result of the change? Something along the lines of:
| - Remove cluster provider from schema | |
| - Due to https://github.com/pulumi/pulumi/issues/7012 including the provider in the generated SDK never really worked. This is removed now. Note - existing uses in Nodejs should not be affected. |
|
This is a breaking change - right? Building on @viveklak's comment - probably worth adding to the CHANGELOG at least here. |
This is breaking for non-TS SDKs - but the code never actually worked in those providers which is why we chose to take it on - I will make sure we prefix this as a breaking change |
fixes #602