Hide debug logs on startup #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwahbe
added
the
needs-release/patch
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
There was a problem hiding this comment.
I think there's a few other providers with issues related to this, e.g. pulumi/pulumi-ise#9 - do we have a bridge issue to link this to?
guineveresaenger
approved these changes
Oct 7, 2024
Users were seeing unhelpful & extremely distracting [DEBUG] logs from `init` time. This commit hides the debug logs between when `init` is called for databricks/terraform-provider-databricks and when `init` is called for github.com/pulumi/pulumi-databricks/provider. Fixes #474
iwahbe
force-pushed
the
iwahbe/474/hide-debug-logs-on-startup
branch
from
15961ff to
593ca4b
Compare
iwahbe
removed
the
needs-release/patch
|
This PR has been shipped in release v1.51.0. |
iwahbe
added a commit
to pulumi/pulumi
that referenced
this pull request
Dec 6, 2024
This commit changes the log level from plugin stdout&stderr to debug, from info. This change is significant because info is shown by default to users, but debug is not. While this is a change of plugin aesthetics, it does not effect any runtime behavior. All plugins, both component providers and custom resource providers, are effected. > [!IMPORTANT] > This is a breaking change, in that information which used to be displayed to users will > now be hidden by default. > > We will need to share this change with our users before rolling it out. The providers team has met and believe that this is the best approach for our ecosystem. For a full discussion on why this change is necessary, see [this doc](https://docs.google.com/document/d/1yYrwTwsNoayaIzKyG1l5cl0MjJxiHLsH4NqAvZkQN-I/edit?tab=t.0#heading=h.34v61lg1x4kl). Fixes pulumi/pulumi-terraform-bridge#2489 Fixes pulumi/pulumi-cloudngfwaws#23 Fixes pulumi/pulumi-ise#9 Taking this change will allow us to revert: - pulumi/pulumi-databricks#609 - pulumi/pulumi-aws#4650
iwahbe
added a commit
to pulumi/pulumi
that referenced
this pull request
Dec 6, 2024
This commit changes the log level from plugin stdout&stderr to debug, from info. This change is significant because info is shown by default to users, but debug is not. While this is a change of plugin aesthetics, it does not effect any runtime behavior. All plugins, both component providers and custom resource providers, are effected. > [!IMPORTANT] > This is a breaking change, in that information which used to be displayed to users will > now be hidden by default. > > We will need to share this change with our users before rolling it out. The providers team has met and believe that this is the best approach for our ecosystem. For a full discussion on why this change is necessary, see [this doc](https://docs.google.com/document/d/1yYrwTwsNoayaIzKyG1l5cl0MjJxiHLsH4NqAvZkQN-I/edit?tab=t.0#heading=h.34v61lg1x4kl). Fixes pulumi/pulumi-terraform-bridge#2489 Fixes pulumi/pulumi-cloudngfwaws#23 Fixes pulumi/pulumi-ise#9 Taking this change will allow us to revert: - pulumi/pulumi-databricks#609 - pulumi/pulumi-aws#4650
iwahbe
added a commit
to pulumi/pulumi
that referenced
this pull request
Dec 6, 2024
This commit changes the log level from plugin stdout&stderr to debug, from info. This change is significant because info is shown by default to users, but debug is not. While this is a change of plugin aesthetics, it does not effect any runtime behavior. All plugins, both component providers and custom resource providers, are effected. > [!IMPORTANT] > This is a breaking change, in that information which used to be displayed to users will > now be hidden by default. > > We will need to share this change with our users before rolling it out. The providers team has met and believe that this is the best approach for our ecosystem. For a full discussion on why this change is necessary, see [this doc](https://docs.google.com/document/d/1yYrwTwsNoayaIzKyG1l5cl0MjJxiHLsH4NqAvZkQN-I/edit?tab=t.0#heading=h.34v61lg1x4kl). Fixes pulumi/pulumi-terraform-bridge#2489 Fixes pulumi/pulumi-cloudngfwaws#23 Fixes pulumi/pulumi-ise#9 Taking this change will allow us to revert: - pulumi/pulumi-databricks#609 - pulumi/pulumi-aws#4650
iwahbe
added a commit
to pulumi/pulumi
that referenced
this pull request
Dec 9, 2024
This commit changes the log level from plugin stdout&stderr to debug, from info. This change is significant because info is shown by default to users, but debug is not. While this is a change of plugin aesthetics, it does not effect any runtime behavior. All plugins, both component providers and custom resource providers, are effected. > [!IMPORTANT] > This is a breaking change, in that information which used to be displayed to users will > now be hidden by default. > > We will need to share this change with our users before rolling it out. The providers team has met and believe that this is the best approach for our ecosystem. For a full discussion on why this change is necessary, see [this doc](https://docs.google.com/document/d/1yYrwTwsNoayaIzKyG1l5cl0MjJxiHLsH4NqAvZkQN-I/edit?tab=t.0#heading=h.34v61lg1x4kl). Fixes pulumi/pulumi-terraform-bridge#2489 Fixes pulumi/pulumi-cloudngfwaws#23 Fixes pulumi/pulumi-ise#9 Taking this change will allow us to revert: - pulumi/pulumi-databricks#609 - pulumi/pulumi-aws#4650 --- When a provider exists ungracefully, we dump *all* unstructured logs to the user. This allows providers to output stack traces to users (so they can report them) when a provider fails. We do not search for `panic` messages to isolate the stack trace, since we cannot do that effectively in a cross-language way.
iwahbe
added a commit
to pulumi/pulumi
that referenced
this pull request
Dec 9, 2024
This commit changes the log level from plugin stdout&stderr to debug, from info. This change is significant because info is shown by default to users, but debug is not. While this is a change of plugin aesthetics, it does not effect any runtime behavior. All plugins, both component providers and custom resource providers, are effected. > [!IMPORTANT] > This is a breaking change, in that information which used to be displayed to users will > now be hidden by default. > > We will need to share this change with our users before rolling it out. The providers team has met and believe that this is the best approach for our ecosystem. For a full discussion on why this change is necessary, see [this doc](https://docs.google.com/document/d/1yYrwTwsNoayaIzKyG1l5cl0MjJxiHLsH4NqAvZkQN-I/edit?tab=t.0#heading=h.34v61lg1x4kl). Fixes pulumi/pulumi-terraform-bridge#2489 Fixes pulumi/pulumi-cloudngfwaws#23 Fixes pulumi/pulumi-ise#9 Taking this change will allow us to revert: - pulumi/pulumi-databricks#609 - pulumi/pulumi-aws#4650 --- When a provider exists ungracefully, we dump *all* unstructured logs to the user. This allows providers to output stack traces to users (so they can report them) when a provider fails. We do not search for `panic` messages to isolate the stack trace, since we cannot do that effectively in a cross-language way.
iwahbe
added a commit
to pulumi/pulumi
that referenced
this pull request
Dec 12, 2024
This commit changes the log level from plugin stdout&stderr to debug, from info. This change is significant because info is shown by default to users, but debug is not. While this is a change of plugin aesthetics, it does not effect any runtime behavior. All plugins, both component providers and custom resource providers, are effected. > [!IMPORTANT] > This is a breaking change, in that information which used to be displayed to users will > now be hidden by default. > > We will need to share this change with our users before rolling it out. The providers team has met and believe that this is the best approach for our ecosystem. For a full discussion on why this change is necessary, see [this doc](https://docs.google.com/document/d/1yYrwTwsNoayaIzKyG1l5cl0MjJxiHLsH4NqAvZkQN-I/edit?tab=t.0#heading=h.34v61lg1x4kl). Fixes pulumi/pulumi-terraform-bridge#2489 Fixes pulumi/pulumi-cloudngfwaws#23 Fixes pulumi/pulumi-ise#9 Taking this change will allow us to revert: - pulumi/pulumi-databricks#609 - pulumi/pulumi-aws#4650 --- When a provider exists ungracefully, we dump *all* unstructured logs to the user. This allows providers to output stack traces to users (so they can report them) when a provider fails. We do not search for `panic` messages to isolate the stack trace, since we cannot do that effectively in a cross-language way.
iwahbe
added a commit
to pulumi/pulumi
that referenced
this pull request
Dec 12, 2024
This commit changes the log level from plugin stdout&stderr to debug, from info. This change is significant because info is shown by default to users, but debug is not. While this is a change of plugin aesthetics, it does not effect any runtime behavior. All plugins, both component providers and custom resource providers, are effected. > [!IMPORTANT] > This is a breaking change, in that information which used to be displayed to users will > now be hidden by default. > > We will need to share this change with our users before rolling it out. The providers team has met and believe that this is the best approach for our ecosystem. For a full discussion on why this change is necessary, see [this doc](https://docs.google.com/document/d/1yYrwTwsNoayaIzKyG1l5cl0MjJxiHLsH4NqAvZkQN-I/edit?tab=t.0#heading=h.34v61lg1x4kl). Fixes pulumi/pulumi-terraform-bridge#2489 Fixes pulumi/pulumi-cloudngfwaws#23 Fixes pulumi/pulumi-ise#9 Taking this change will allow us to revert: - pulumi/pulumi-databricks#609 - pulumi/pulumi-aws#4650 --- When a provider exists ungracefully, we dump *all* unstructured logs to the user. This allows providers to output stack traces to users (so they can report them) when a provider fails. We do not search for `panic` messages to isolate the stack trace, since we cannot do that effectively in a cross-language way.
iwahbe
added a commit
to pulumi/pulumi
that referenced
this pull request
Dec 12, 2024
This commit changes the log level from plugin stdout&stderr to debug, from info. This change is significant because info is shown by default to users, but debug is not. While this is a change of plugin aesthetics, it does not effect any runtime behavior. All plugins, both component providers and custom resource providers, are effected. > [!IMPORTANT] > This is a breaking change, in that information which used to be displayed to users will > now be hidden by default. > > We will need to share this change with our users before rolling it out. The providers team has met and believe that this is the best approach for our ecosystem. For a full discussion on why this change is necessary, see [this doc](https://docs.google.com/document/d/1yYrwTwsNoayaIzKyG1l5cl0MjJxiHLsH4NqAvZkQN-I/edit?tab=t.0#heading=h.34v61lg1x4kl). Fixes pulumi/pulumi-terraform-bridge#2489 Fixes pulumi/pulumi-cloudngfwaws#23 Fixes pulumi/pulumi-ise#9 Taking this change will allow us to revert: - pulumi/pulumi-databricks#609 - pulumi/pulumi-aws#4650 --- When a provider exists ungracefully, we dump *all* unstructured logs to the user. This allows providers to output stack traces to users (so they can report them) when a provider fails. We do not search for `panic` messages to isolate the stack trace, since we cannot do that effectively in a cross-language way.
iwahbe
added a commit
to pulumi/pulumi
that referenced
this pull request
Dec 12, 2024
This commit changes the log level from plugin stdout&stderr to debug, from info. This change is significant because info is shown by default to users, but debug is not. While this is a change of plugin aesthetics, it does not effect any runtime behavior. All plugins, both component providers and custom resource providers, are effected. > [!IMPORTANT] > This is a breaking change, in that information which used to be displayed to users will > now be hidden by default. > > We will need to share this change with our users before rolling it out. The providers team has met and believe that this is the best approach for our ecosystem. For a full discussion on why this change is necessary, see [this doc](https://docs.google.com/document/d/1yYrwTwsNoayaIzKyG1l5cl0MjJxiHLsH4NqAvZkQN-I/edit?tab=t.0#heading=h.34v61lg1x4kl). Fixes pulumi/pulumi-terraform-bridge#2489 Fixes pulumi/pulumi-cloudngfwaws#23 Fixes pulumi/pulumi-ise#9 Taking this change will allow us to revert: - pulumi/pulumi-databricks#609 - pulumi/pulumi-aws#4650 --- When a provider exists ungracefully, we dump *all* unstructured logs to the user. This allows providers to output stack traces to users (so they can report them) when a provider fails. We do not search for `panic` messages to isolate the stack trace, since we cannot do that effectively in a cross-language way.
github-merge-queue bot
pushed a commit
to pulumi/pulumi
that referenced
this pull request
Dec 12, 2024
This commit changes the log level from plugin stdout&stderr to debug, from info. This change is significant because info is shown by default to users, but debug is not. While this is a change of plugin aesthetics, it does not effect any runtime behavior. All plugins, both component providers and custom resource providers, are effected. > [!IMPORTANT] > This is a breaking change, in that information which used to be displayed to users will > now be hidden by default. > > We will need to share this change with our users before rolling it out. The providers team has met and believe that this is the best approach for our ecosystem. For a full discussion on why this change is necessary, see [this doc](https://docs.google.com/document/d/1yYrwTwsNoayaIzKyG1l5cl0MjJxiHLsH4NqAvZkQN-I/edit?tab=t.0#heading=h.34v61lg1x4kl). Fixes pulumi/pulumi-terraform-bridge#2489 Fixes pulumi/pulumi-cloudngfwaws#23 Fixes pulumi/pulumi-ise#9 Taking this change will allow us to revert: - pulumi/pulumi-databricks#609 - pulumi/pulumi-aws#4650 --- When a provider exists ungracefully, we dump *all* unstructured logs to the user. This allows providers to output stack traces to users (so they can report them) when a provider fails. We do not search for `panic` messages to isolate the stack trace, since we cannot do that effectively in a cross-language way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users were seeing unhelpful & extremely distracting [DEBUG] logs from
inittime. This commit hides the debug logs between wheninitis called for databricks/terraform-provider-databricks and wheninitis called for github.com/pulumi/pulumi-databricks/provider.Fixes #474