Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate away from use of go-autorest for authentication #1566

Closed
viveklak opened this issue Mar 11, 2022 · 1 comment
Closed

Migrate away from use of go-autorest for authentication #1566

viveklak opened this issue Mar 11, 2022 · 1 comment
Assignees
@thomas11
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@viveklak
Copy link
Contributor

viveklak commented Mar 11, 2022 •
edited
Loading

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

As per Azure/go-autorest#636 - with the push to migrate from ADAL to MSAL, the use of go-autorest for authentication is starting to cause issues. See #1565 for instance. It appears there is no plan to add MSAL authentication support to go-autorest and the proposal is to use the azidentity package in the AZ go sdk: https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/azidentity. We should migrate to this model for the azure-native provider.

Affected area/feature

  • getClientConfig
  • Authentication
@viveklak viveklak added the kind/enhancement Improvements or new features label Mar 11, 2022
@stack72
Copy link
Contributor

stack72 commented Jul 7, 2022

So @danielrbradley and I just had a small conversation about this and after some small thoughts we believe:

  • We should support BOTH authentication styles for an undetermined period of time to allow transition
  • the current authentication system will stay the default BUT we should be able to opt-in to the new authentication system
    • pulumi config set azure-native:auth future true or a determined config name
  • This work will not happen as part of the 2.0 launch but will be the first thing we handle after the 2.0 work
  • in 3.0, the future authentication will be made the default experience

This was referenced Aug 18, 2022
Closed
Closed
thomas11 added a commit that referenced this issue Aug 19, 2022
@thomas11
First working iteration of using azidentity (MSAL) to get an auth tok…
684c195 
…en. #1566
thomas11 added a commit that referenced this issue Aug 19, 2022
@thomas11
First working iteration of using azidentity (MSAL) to get an auth tok…
8a82d02 
…en. #1566
thomas11 added a commit that referenced this issue Aug 19, 2022
@thomas11
Add simple acceptance test that returns a token to inspect. #1566
f08e4c8
thomas11 added a commit that referenced this issue Aug 19, 2022
@thomas11
Clean up dev code (but leave old func for now) #1566
a28c407
@stack72 stack72 added this to the 0.77 milestone Aug 19, 2022
thomas11 added a commit that referenced this issue Aug 19, 2022
@thomas11
[nit] replace if-else cascade by switch #1566
71cfff0
thomas11 added a commit that referenced this issue Aug 23, 2022
@thomas11
First working iteration of using azidentity (MSAL) to get an auth tok…
67dc55c 
…en. #1566
thomas11 added a commit that referenced this issue Aug 23, 2022
@thomas11
Add simple acceptance test that returns a token to inspect. #1566
b962b37
thomas11 added a commit that referenced this issue Aug 23, 2022
@thomas11
Clean up dev code (but leave old func for now) #1566
fa85ed6
thomas11 added a commit that referenced this issue Aug 23, 2022
@thomas11
[nit] replace if-else cascade by switch #1566
0f6cd9a
thomas11 added a commit that referenced this issue Aug 23, 2022
@thomas11
go mod tidy #1566
f4f35a5
thomas11 added a commit that referenced this issue Aug 23, 2022
@thomas11
First working iteration of using azidentity (MSAL) to get an auth tok…
94cb78e 
…en. #1566
thomas11 added a commit that referenced this issue Aug 23, 2022
@thomas11
Add simple acceptance test that returns a token to inspect. #1566
1d241f6
thomas11 added a commit that referenced this issue Aug 23, 2022
@thomas11
Clean up dev code (but leave old func for now) #1566
84aa4b2
thomas11 added a commit that referenced this issue Aug 23, 2022
@thomas11
[nit] replace if-else cascade by switch #1566
44ead7b
thomas11 added a commit that referenced this issue Aug 23, 2022
@thomas11
go mod tidy #1566
3efe30a
thomas11 added a commit that referenced this issue Aug 23, 2022
@thomas11
Use ADAL for multitenant auth or when requested. #1566
e33a3eb
thomas11 added a commit that referenced this issue Aug 23, 2022
@thomas11
Print a warning when USE_LEGACY_ADAL_AUTH is set. #1566
2c66daf
thomas11 added a commit that referenced this issue Aug 24, 2022
@thomas11
First working iteration of using azidentity (MSAL) to get an auth tok…
a63524b 
…en. #1566
thomas11 added a commit that referenced this issue Aug 24, 2022
@thomas11
Add simple acceptance test that returns a token to inspect. #1566
86e6f2b
thomas11 added a commit that referenced this issue Aug 24, 2022
@thomas11
Clean up dev code (but leave old func for now) #1566
a9dfd45
thomas11 added a commit that referenced this issue Aug 24, 2022
@thomas11
[nit] replace if-else cascade by switch #1566
8f93d46
thomas11 added a commit that referenced this issue Aug 24, 2022
@thomas11
go mod tidy #1566
ccbe54a
thomas11 added a commit that referenced this issue Aug 24, 2022
@thomas11
Use ADAL for multitenant auth or when requested. #1566
0c8a108
thomas11 added a commit that referenced this issue Aug 24, 2022
@thomas11
Print a warning when USE_LEGACY_ADAL_AUTH is set. #1566
324583a
thomas11 added a commit that referenced this issue Aug 26, 2022
@thomas11
Move deprecation warning to better place to show only once #1566
316d69c
@thomas11 thomas11 mentioned this issue Aug 29, 2022
Closed
@thomas11 thomas11 modified the milestones: 0.77, 0.78 Sep 6, 2022
@lukehoban lukehoban modified the milestones: 0.78, 0.79 Oct 6, 2022
thomas11 added a commit that referenced this issue Oct 7, 2022
@thomas11
Use correct audience for MSAL Key Vault token #1566
f889a71
thomas11 added a commit that referenced this issue Oct 7, 2022
@thomas11
fixup! Use correct audience for MSAL Key Vault token #1566
f12d285
@lukehoban lukehoban modified the milestones: 0.79, 0.80 Nov 7, 2022
@mikhailshilkov mikhailshilkov removed this from the 0.80 milestone Nov 15, 2022
thomas11 added a commit that referenced this issue Jan 20, 2023
@thomas11
Use correct audience for MSAL Key Vault token #1566
f726d8b
thomas11 added a commit that referenced this issue Jan 20, 2023
@thomas11
fixup! Use correct audience for MSAL Key Vault token #1566
d47c63c
thomas11 added a commit that referenced this issue Feb 6, 2023
@thomas11
Use correct audience for MSAL Key Vault token #1566
e08be81
thomas11 added a commit that referenced this issue Feb 8, 2023
@thomas11
Use correct audience for MSAL Key Vault token #1566
1a52c5d
thomas11 added a commit that referenced this issue Feb 9, 2023
@thomas11
Use correct audience for MSAL Key Vault token #1566
427984c
thomas11 added a commit that referenced this issue Feb 10, 2023
@thomas11
Use correct audience for MSAL Key Vault token #1566
6d0a17e
thomas11 added a commit that referenced this issue Feb 14, 2023
@thomas11
Use correct audience for MSAL Key Vault token #1566
8dd628d
thomas11 added a commit that referenced this issue Mar 15, 2023
@thomas11
Use correct audience for MSAL Key Vault token #1566
ecb9c69
thomas11 added a commit that referenced this issue Mar 17, 2023
@thomas11
Use correct audience for MSAL Key Vault token #1566
1f0e274
thomas11 added a commit that referenced this issue Mar 17, 2023
@thomas11
Use correct audience for MSAL Key Vault token #1566
2cfd825
thomas11 added a commit that referenced this issue Mar 21, 2023
@thomas11
Use correct audience for MSAL Key Vault token #1566
2acbab0
thomas11 added a commit that referenced this issue Mar 22, 2023
@thomas11
Use correct audience for MSAL Key Vault token #1566
c256cfc
@thomas11 thomas11 added the resolution/fixed This issue was fixed label Aug 9, 2023
@thomas11 thomas11 closed this as completed Aug 9, 2023
julienp added a commit to pulumi/pulumi-docker-containers that referenced this issue Jul 25, 2024
@julienp
Unpin Azure CLI version
e83dd6f 
We had previously pinned `az` to version 2.33.1 to work around an issue
with a deprecation warning. The underlying issue in the Azure SDK has
since been fixed in pulumi/pulumi-azure-native#1566
@julienp julienp mentioned this issue Jul 25, 2024
Merged
julienp added a commit to pulumi/pulumi-docker-containers that referenced this issue Jul 30, 2024
@julienp
Unpin Azure CLI version
75a219d 
We had previously pinned `az` to version 2.33.1 to work around an issue
with a deprecation warning. The underlying issue in the Azure SDK has
since been fixed in pulumi/pulumi-azure-native#1566
julienp added a commit to pulumi/pulumi-docker-containers that referenced this issue Jul 30, 2024
@julienp
Unpin Azure CLI version (#214)
b6801a0 
We had previously pinned `az` to version 2.33.1 to work around an issue
with a deprecation warning. The underlying issue in the Azure SDK has
since been fixed in
pulumi/pulumi-azure-native#1566

Note: we have tests that check that the `az` works (= can login and get
account info)
Source-Controller pushed a commit to Source-Controller/Pulumi-Docker that referenced this issue Oct 17, 2024
@julienp
Unpin Azure CLI version (#214)
2539bcc 
We had previously pinned `az` to version 2.33.1 to work around an issue
with a deprecation warning. The underlying issue in the Azure SDK has
since been fixed in
pulumi/pulumi-azure-native#1566

Note: we have tests that check that the `az` works (= can login and get
account info)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomas11 thomas11

Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@thomas11 @lukehoban @stack72 @viveklak @mikhailshilkov