Update ecs types #616
Merged
Update ecs types #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The awsx.ecs types have drifted a little relative to the aws.ecs types. This change brings them up to date with the latest types in the AWS package. In particular this adds: * Container#interactive * ServiceArgs#forceNewDeployment * TaskDefinitionArgs#inferenceAccelerators * TaskDefinitionArgs#ipcMode * TaskDefinitionArgs#pidMode * TaskDefinitionArgs#proxyConfiguration Aside: The implementation includes an Override type that attempts to derive the correct type from the upstream types. If this had been used directly, it would have avoided the need for this maintenance. But documentation and error message experiences in TypeScript are not good for these derived types, so we instead also manually maintain a copy of the types. We then attempt to verify that the manually maintained copy is compatible, but that attempt only verifies required properties, leaving the possibility that drift in optional properties (which in practice is the only kind of drift that can happen) will not be caught. We likely need to revisit the overall strategy here. Fixes #615.
lukehoban
force-pushed
the
lukehoban/615
branch
from
e2a329c to
3557de8
Compare
lukehoban
force-pushed
the
lukehoban/615
branch
from
3557de8 to
be407fa
Compare
stack72
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The awsx.ecs types have drifted a little relative to the aws.ecs types. This change brings them up to date with the latest types in the AWS package. In particular this adds:
Container#interactiveServiceArgs#forceNewDeploymentTaskDefinitionArgs#inferenceAcceleratorsTaskDefinitionArgs#ipcModeTaskDefinitionArgs#pidModeTaskDefinitionArgs#proxyConfigurationAside: The implementation includes an Override type that attempts to derive the correct type from the upstream types. If this had been used directly, it would have avoided the need for this maintenance. But documentation and error message experiences in TypeScript are not good for these derived types, so we instead also manually maintain a copy of the types. We then attempt to verify that the manually maintained copy is compatible, but that attempt only verifies required properties, leaving the possibility that drift in optional properties (which in practice is the only kind of drift that can happen) will not be caught. We likely need to revisit the overall strategy here.
Fixes #615.