Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ListenerActions in TargetGroup #503

Closed
wants to merge 1 commit into from
Closed

Implement ListenerActions in TargetGroup #503

wants to merge 1 commit into from

Conversation

ypresto
Copy link

@ypresto ypresto commented Feb 1, 2020 •
edited
Loading

We can pass targetGroup to actions with this PR:

listener.addListenerRule('listener-rule', {
  conditions: [{ pathPattern: { values: ['/directory/*'] } }],
  actions: targetGroup,
  priority: 10
})

@ypresto ypresto force-pushed the target-group-listener-actions branch from f4ed76d to 17314d8 Compare February 1, 2020 08:36
benmccann
benmccann reviewed Jul 29, 2020
View reviewed changes
CHANGELOG.md
@@ -11,6 +11,9 @@ CHANGELOG
- Explicitly require `@pulumi/pulumi@>=1.9.1` as it contains an API that awsx depends on.
[#492](https://github.com/pulumi/pulumi-awsx/pull/492)

- Allow the user to pass `TargetGroup` as `actions` of `ListenerRule`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go in the "Unreleased" section

@leezen
Copy link
Contributor

leezen commented Nov 17, 2020

@ypresto Did you still want to try to update this PR for merging?

@stack72 stack72 mentioned this pull request Jan 19, 2021
Merged
@stack72
Copy link
Contributor

stack72 commented Jan 19, 2021

Closed via #621

@stack72 stack72 closed this Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ypresto @leezen @stack72 @benmccann