-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Vpc's asynchronous, and remove all usages of deasync
library.
#470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Dec 19, 2019
@@ -10,6 +10,7 @@ TESTPARALLELISM := 10 | |||
|
|||
build:: | |||
yarn install | |||
tsc --version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was helpful when tracking down some issues. i'd like to keep it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be reviewed with whitespace changes off.
Due the necessity to perform many async operations during creation, many parts of an
[awsx.ec2.Vpc] have become asynchronous. This is encoded using the normal
Output<awsx.ec2.Vpc>
type. However, for convenience, many parts are also available as
Promise
s, making it easy to usefrom
async
code. Specifically:awsx.ec2.Vpc.vpc
has changed from anaws.ec2.Vpc
to anOutput<aws.ec2.Vpc>
.awsx.ec2.Vpc
(likepublicSubnetIds
) are nowasync (i.e.
Promise<Output<string>[]>
).These changes should not impact most code. Code that creates and passes around a Vpc or accesses
properties off of the Vpc should continue to work. If there is code that needs to access the raw
values (for example, to iterate over the subnets of a Vpc) that can be written like so: