Flaky TestAccEcsCapacityProviderService

[t0yv0]

Failed with:

    aws:ecs:Service (my-service):
      error:   sdk-v2/provider2.go:520: sdk.helper_schema: creating ECS Service (my-service-9669d07): operation error ECS: CreateService, https response error StatusCode: 400, RequestID: 187a5383-55d4-4df4-b185-0f69370c60cf, InvalidParameterException: The target group with targetGroupArn arn:aws:elasticloadbalancing:us-west-2:894850187425:targetgroup/nginx-lb-111793d/91d31eae55038f3a does not have an associated load balancer.: [email protected]
      error: 1 error occurred:
      	* creating ECS Service (my-service-9669d07): operation error ECS: CreateService, https response error StatusCode: 400, RequestID: 187a5383-55d4-4df4-b185-0f69370c60cf, InvalidParameterException: The target group with targetGroupArn arn:aws:elasticloadbalancing:us-west-2:894850187425:targetgroup/nginx-lb-111793d/91d31eae55038f3a does not have an associated load balancer.

But restarting CI fixed the test.

[t0yv0]

I suspect there is actually a data race in the example from a missing dependency:

 +   pulumi:pulumi:Stack                           ecs-node-awsx-examples-ecs-nodejs  creating (168s).    
 +   ├─ aws:lb:ApplicationLoadBalancer             nginx-lb                           created (1s)
 +   │  ├─ awsx:lb:ApplicationListener             nginx-lb                           created (1s)
 +   │  │  ├─ awsx:x:ec2:IngressSecurityGroupRule  nginx-lb-external-0-ingress        created (1s)
 +   │  │  │  └─ aws:ec2:SecurityGroupRule         nginx-lb-external-0-ingress        created (1s)
 +   │  │  └─ awsx:x:ec2:EgressSecurityGroupRule   nginx-lb-external-0-egress         created (2s)
 +   │  │     └─ aws:ec2:SecurityGroupRule         nginx-lb-external-0-egress         created (1s)
 +   │  ├─ awsx:lb:ApplicationTargetGroup          nginx-lb                           created (2s)
 +   │  │  └─ aws:lb:TargetGroup                   nginx-lb                           created (3s)    ###### <--- ##### 
 +   │  └─ aws:lb:LoadBalancer                     nginx-lb                           creating (156s) ###### <--- ##### 
 +   ├─ awsx:x:ecs:Cluster                         cluster                            created (1s)
 +   │  ├─ awsx:x:ec2:SecurityGroup                cluster                            created (1s)
 +   │  │  ├─ awsx:x:ec2:IngressSecurityGroupRule  cluster-ssh                        created (3s)
 +   │  │  │  └─ aws:ec2:SecurityGroupRule         cluster-ssh                        created (1s)
 +   │  │  ├─ awsx:x:ec2:EgressSecurityGroupRule   cluster-egress                     created (4s)
 +   │  │  │  └─ aws:ec2:SecurityGroupRule         cluster-egress                     created (3s)
 +   │  │  ├─ awsx:x:ec2:IngressSecurityGroupRule  cluster-containers                 created (5s)
 +   │  │  │  └─ aws:ec2:SecurityGroupRule         cluster-containers                 created (2s)
 +   │  │  └─ aws:ec2:SecurityGroup                cluster                            created (3s)
 +   │  └─ aws:ecs:Cluster                         cluster                            created (12s)
 +   ├─ awsx:x:ec2:SecurityGroup                   nginx-lb                           created (1s)
 +   │  └─ aws:ec2:SecurityGroup                   nginx-lb                           created (3s)
 +   ├─ awsx:x:ec2:Vpc                             default-vpc                        created (2s)
 +   │  ├─ awsx:x:ec2:Subnet                       default-vpc-public-1               created (2s)
 +   │  └─ awsx:x:ec2:Subnet                       default-vpc-public-0               created (2s)
 +   ├─ awsx:ecs:FargateTaskDefinition             fargate-task                       created (1s)
 +   │  ├─ aws:iam:Role                            fargate-task-execution             created (0.79s)
 +   │  ├─ aws:cloudwatch:LogGroup                 fargate-task                       created (1s)
 +   │  ├─ aws:iam:Role                            fargate-task-task                  created (0.79s)
 +   │  ├─ aws:iam:RolePolicyAttachment            fargate-task-execution-9a42f520    created (0.65s)
 +   │  └─ aws:ecs:TaskDefinition                  fargate-task                       created (0.95s)
 +   └─ awsx:ecs:FargateService                    my-service                         created (0.40s)
 +      └─ aws:ecs:Service                         my-service                         creating (147s).. ###### <--- ##### 

[t0yv0]

The theory is that aws:ecs:Service starts creating before waiting on aws:lb:LoadBalancer to finish creating, aws:lb:TargetGroup has already been created but nothing here depends formally on the LB.

Looking at the dependencies from the state file.

ECS service:
"urn:pulumi:awsx-examples-ecs-nodejs::ecs-node::awsx:ecs:FargateService$aws:ecs/service:Service::my-service"

Depends on:
"urn:pulumi:awsx-examples-ecs-nodejs::ecs-node::awsx:ecs:FargateTaskDefinition$aws:ecs/taskDefinition:TaskDefinition::fargate-task"

Which in turn depends on the target group:

            "dependencies": [
                "urn:pulumi:awsx-examples-ecs-nodejs::ecs-node::aws:lb:ApplicationLoadBalancer$awsx:lb:ApplicationTargetGroup$aws:lb/targetGroup:TargetGroup::nginx-lb"
            ],

Which only depends on the VPC:
"urn:pulumi:awsx-examples-ecs-nodejs::ecs-node::aws:ec2/vpc:Vpc::default-vpc"

[pulumi-bot]

This issue has been addressed in PR #1441 and shipped in release v2.20.0.