-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream v5.74.0 #4714
Upstream v5.74.0 #4714
Conversation
Does the PR have any schema changes?Found 3 breaking changes: Types
New resources:
New functions:
Maintainer note: consult the runbook for dealing with any breaking changes. |
What about the breaking change in the Upstream changed the output to use |
The upstream PR that introduced it makes it seem that this is a bug fix and not a breaking change because the value was actually a string under the hood before: hashicorp/terraform-provider-aws#39928 Worth checking if that's also the case for pulumi, in that case we should be good to take the change. |
I have filed #4723 to consider - there is a way to project these as booleans but we had some trouble with skipMetadataApiCheck as this complicates the job for the bridge. Currently this projects as a string:
I would not block the release on this unless we believe this data source is widely used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're good with the breaking changes in the data source. That change is actually a bug fix
This PR has been shipped in release v6.58.0. |
Upgrade upstream to v5.74.0
New resources:
opensearch/authorizeVpcEndpointAccess.AuthorizeVpcEndpointAccess
ssm/quicksetupConfigurationManager.QuicksetupConfigurationManager
New functions:
lb/getListenerRule.getListenerRule
Fixes #4707