Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream v5.74.0 #4714

Merged
merged 8 commits into from
Nov 6, 2024
Merged

Upstream v5.74.0 #4714

merged 8 commits into from
Nov 6, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Nov 4, 2024

Upgrade upstream to v5.74.0

New resources:

opensearch/authorizeVpcEndpointAccess.AuthorizeVpcEndpointAccess
ssm/quicksetupConfigurationManager.QuicksetupConfigurationManager

New functions:

lb/getListenerRule.getListenerRule

Fixes #4707

Copy link

github-actions bot commented Nov 4, 2024

Does the PR have any schema changes?

Found 3 breaking changes:

Types

  • 🟢 "aws:imagebuilder/getDistributionConfigurationDistribution:getDistributionConfigurationDistribution": required: "s3ExportConfigurations" property has changed to Required
  • "aws:imagebuilder/getImageRecipeBlockDeviceMappingEb:getImageRecipeBlockDeviceMappingEb": properties:
    • 🟡 "deleteOnTermination" type changed from "boolean" to "string"
    • 🟡 "encrypted" type changed from "boolean" to "string"

New resources:

  • opensearch/authorizeVpcEndpointAccess.AuthorizeVpcEndpointAccess
  • ssm/quicksetupConfigurationManager.QuicksetupConfigurationManager

New functions:

  • lb/getListenerRule.getListenerRule

Maintainer note: consult the runbook for dealing with any breaking changes.

@t0yv0 t0yv0 marked this pull request as ready for review November 5, 2024 18:23
@t0yv0 t0yv0 requested a review from flostadler November 5, 2024 18:23
@flostadler
Copy link
Contributor

flostadler commented Nov 6, 2024

What about the breaking change in the getImageRecipe function?

Upstream changed the output to use TypeNullableBool for the deleteOnTermination and encrypted here. That type is a string under the hood, is there something we can do on the pulumi side to properly represent this as an optional bool? I guess we'd need pulumi/pulumi-terraform-bridge#1514 for that

@flostadler
Copy link
Contributor

flostadler commented Nov 6, 2024

The upstream PR that introduced it makes it seem that this is a bug fix and not a breaking change because the value was actually a string under the hood before: hashicorp/terraform-provider-aws#39928

Worth checking if that's also the case for pulumi, in that case we should be good to take the change.

@t0yv0
Copy link
Member Author

t0yv0 commented Nov 6, 2024

I have filed #4723 to consider - there is a way to project these as booleans but we had some trouble with skipMetadataApiCheck as this complicates the job for the bridge. Currently this projects as a string:

    export interface GetImageRecipeBlockDeviceMappingEb {
        /**
         * Whether to delete the volume on termination. Defaults to unset, which is the value inherited from the parent image.
         */
        deleteOnTermination: string;
        /**
         * Whether to encrypt the volume. Defaults to unset, which is the value inherited from the parent image.
         */

I would not block the release on this unless we believe this data source is widely used.

@t0yv0 t0yv0 requested a review from corymhall November 6, 2024 15:59
Copy link
Contributor

@flostadler flostadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good with the breaking changes in the data source. That change is actually a bug fix

@t0yv0 t0yv0 merged commit 7471984 into master Nov 6, 2024
33 checks passed
@t0yv0 t0yv0 deleted the upstream-v5.74.0 branch November 6, 2024 16:54
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v6.58.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade terraform-provider-aws to v5.74.0
3 participants