Upstream v5.73.0 #4674
Upstream v5.73.0 #4674
Conversation
t0yv0
force-pushed
the
upstream-v5.72.1
branch
from
e9e0fa2 to
573efad
Compare
t0yv0
force-pushed
the
upstream-v5.73.0
branch
from
4edf2a8 to
3c90b36
Compare
Does the PR have any schema changes?Found 1 breaking change: Types
New resources:
New functions:
Maintainer note: consult the runbook for dealing with any breaking changes. |
t0yv0
force-pushed
the
upstream-v5.73.0
branch
from
9bafa87 to
6da53e0
Compare
| - tftags "github.com/hashicorp/terraform-provider-aws/internal/tags" | ||
| ) | ||
|
|
||
| -// Find JSON diff functions in the json.go file. |
There was a problem hiding this comment.
Do you know what is going on with this change?
| - | ||
| return nil | ||
| } | ||
| + // Pulumi handles tags differently for Plugin Framework. |
There was a problem hiding this comment.
@corymhall yes so as part of this PR I endeavored to minimize subsequent patch conflicts for us. What we want to do is to make this function a no-op. The function keeps changing. If we do this as we did before by deleting the code, the changes generate more conflicts. With this new method we just short-circuit it to nil right upfront, but let the rest of the code drift upstream. I think this is better.
Tests pointing out that reverse-engineering AWS SDKv1 removal need to go a bit deeper, working this out. |
|
ecr/credentials_data_source is maintained by patches and might be affected, need to verify. |
|
@t0yv0 I've added a test for the ECR getCredentials function |
t0yv0
force-pushed
the
upstream-v5.73.0
branch
from
4cfe00b to
3057878
Compare
|
This PR has been shipped in release v6.57.0. |
Upgrade upstream provider to v5.73.0.
New resources:
imagebuilder/lifecyclePolicy.LifecyclePolicy
resiliencehub/resiliencyPolicy.ResiliencyPolicy
sagemaker/hub.Hub
sagemaker/mlflowTrackingServer.MlflowTrackingServer
New functions:
ssm/getPatchBaselines.getPatchBaselines
Fixes: #4665
New patches are taken to compensate for upstream partially removing Go SDKV1, so that Pulumi-only resources such as aws.s3.Bucket continue to work as expected.