Upstream v5.70.0 #4604
Merged
Upstream v5.70.0 #4604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flostadler
commented
Oct 4, 2024
| @@ -5848,9 +5848,18 @@ func setupComputedIDs(prov *tfbridge.ProviderInfo) { | |||
| return attr(state, "functionName"), nil | |||
| } | |||
| prov.Resources["aws_iam_role_policies_exclusive"].ComputeID = func(ctx context.Context, state resource.PropertyMap) (resource.ID, error) { | |||
| return attr(state, "role_name"), nil | |||
| return attr(state, "roleName"), nil | |||
There was a problem hiding this comment.
@t0yv0 @corymhall please correct me if I'm wrong, but I think the computed ID for iam.RolePoliciesExclusive was set wrongly.
flostadler
commented
Oct 4, 2024
| prov.Resources["aws_iam_group_policies_exclusive"].ComputeID = func(ctx context.Context, state resource.PropertyMap) (resource.ID, error) { | ||
| return attr(state, "groupName"), nil | ||
| } | ||
| prov.Resources["aws_iam_user_policies_exclusive"].ComputeID = func(ctx context.Context, state resource.PropertyMap) (resource.ID, error) { |
There was a problem hiding this comment.
flostadler
commented
Oct 4, 2024
| } | ||
| prov.Resources["aws_elasticache_reserved_cache_node"].ComputeID = func(ctx context.Context, state resource.PropertyMap) (resource.ID, error) { | ||
| return attr(state, "id"), nil | ||
| } | ||
| prov.Resources["aws_bedrock_guardrail_version"].ComputeID = func(ctx context.Context, state resource.PropertyMap) (resource.ID, error) { |
There was a problem hiding this comment.
flostadler
commented
Oct 4, 2024
| prov.Resources["aws_bedrock_guardrail_version"].ComputeID = func(ctx context.Context, state resource.PropertyMap) (resource.ID, error) { | ||
| return attr(state, "guardrailArn", "version"), nil | ||
| } | ||
| prov.Resources["aws_iam_group_policies_exclusive"].ComputeID = func(ctx context.Context, state resource.PropertyMap) (resource.ID, error) { |
There was a problem hiding this comment.
Does the PR have any schema changes?Found 1 breaking change: Functions
New resources:
Maintainer note: consult the runbook for dealing with any breaking changes. |
corymhall
approved these changes
Oct 4, 2024
|
This PR has been shipped in release v6.55.0. |
zemnmez-renovate-bot
added a commit
to zemn-me/monorepo
that referenced
this pull request
Oct 7, 2024
##### [`v6.55.0](https://github.com/pulumi/pulumi-aws/releases/tag/v6.55.0) ##### Does the PR have any schema changes? Found 1 breaking change: ##### Functions - `🟡` "aws:securityhub/getStandardsControlAssociations:getStandardsControlAssociations": inputs: "standardsControlAssociations" missing input "standardsControlAssociations" ##### New resources: - `backup/logicallyAirGappedVault.LogicallyAirGappedVault` - `bedrock/guardrailVersion.GuardrailVersion` - `ec2transitgateway/defaultRouteTableAssociation.DefaultRouteTableAssociation` - `ec2transitgateway/defaultRouteTablePropagation.DefaultRouteTablePropagation` - `iam/groupPoliciesExclusive.GroupPoliciesExclusive` - `iam/userPoliciesExclusive.UserPoliciesExclusive` - `securityhub/standardsControlAssociation.StandardsControlAssociation` #### What's Changed - Upstream v5.70.0 by [@flostadler](https://github.com/flostadler) in pulumi/pulumi-aws#4604 - Update GitHub Actions workflows. by [@pulumi-bot](https://github.com/pulumi-bot) in pulumi/pulumi-aws#4608 - Allow running gamelift test in parallel by [@flostadler](https://github.com/flostadler) in pulumi/pulumi-aws#4609 **Full Changelog**: pulumi/pulumi-aws@v6.54.2...v6.55.0
github-merge-queue bot
pushed a commit
to zemn-me/monorepo
that referenced
this pull request
Oct 7, 2024
##### [`v6.55.0](https://github.com/pulumi/pulumi-aws/releases/tag/v6.55.0) ##### Does the PR have any schema changes? Found 1 breaking change: ##### Functions - `🟡` "aws:securityhub/getStandardsControlAssociations:getStandardsControlAssociations": inputs: "standardsControlAssociations" missing input "standardsControlAssociations" ##### New resources: - `backup/logicallyAirGappedVault.LogicallyAirGappedVault` - `bedrock/guardrailVersion.GuardrailVersion` - `ec2transitgateway/defaultRouteTableAssociation.DefaultRouteTableAssociation` - `ec2transitgateway/defaultRouteTablePropagation.DefaultRouteTablePropagation` - `iam/groupPoliciesExclusive.GroupPoliciesExclusive` - `iam/userPoliciesExclusive.UserPoliciesExclusive` - `securityhub/standardsControlAssociation.StandardsControlAssociation` #### What's Changed - Upstream v5.70.0 by [@flostadler](https://github.com/flostadler) in pulumi/pulumi-aws#4604 - Update GitHub Actions workflows. by [@pulumi-bot](https://github.com/pulumi-bot) in pulumi/pulumi-aws#4608 - Allow running gamelift test in parallel by [@flostadler](https://github.com/flostadler) in pulumi/pulumi-aws#4609 **Full Changelog**: pulumi/pulumi-aws@v6.54.2...v6.55.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The detected breaking change in
getStandardsControlAssociationsis expected and benign. The outputstandardsControlAssociationssnuck its way into the inputs in upstream, but it wasn't usable. This PR fixed it upstream: hashicorp/terraform-provider-aws@f2a5704Additionally this corrects the
ComputedIDofaws_iam_role_policies_exclusive.closes #4602