-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust TestRegress2868 to ignore birthdate drift #4159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Any plans on what we do with #4158? In theory we could auto delete the auto injected schema, but I'm a bit wary of introducing a patch for this
I'd let the issue hang around until users demonstrate it's impactful. I suspect it should be reproducing upstream, I can do some more digging to link it upstream before parking. |
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Possibly a flake:
|
@t0yv0 if we see this test flake more often we can increase the timeout. 5min might be a bit too aggressive |
This PR has been shipped in release v6.43.0. |
Some changes in the AWS cloud invalidated TestRegress2868:
#4158
This change works around the problem to continue using TestRegress2868 for its original purposes (see #2868).
Fixes #4152