Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust TestRegress2868 to ignore birthdate drift #4159

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Jul 2, 2024

Some changes in the AWS cloud invalidated TestRegress2868:

#4158

This change works around the problem to continue using TestRegress2868 for its original purposes (see #2868).

Fixes #4152

Some changes in the AWS cloud invalidated TestRegress2868:

   #4158

This change works around the problem to continue using TestRegress2868 for its original purposes (see #2868).
@t0yv0 t0yv0 requested review from corymhall and flostadler July 2, 2024 15:42
Copy link
Contributor

@flostadler flostadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Any plans on what we do with #4158? In theory we could auto delete the auto injected schema, but I'm a bit wary of introducing a patch for this

@t0yv0
Copy link
Member Author

t0yv0 commented Jul 2, 2024

I'd let the issue hang around until users demonstrate it's impactful. I suspect it should be reproducing upstream, I can do some more digging to link it upstream before parking.

@t0yv0 t0yv0 enabled auto-merge (squash) July 2, 2024 15:49
Copy link

github-actions bot commented Jul 2, 2024

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@t0yv0
Copy link
Member Author

t0yv0 commented Jul 2, 2024

Possibly a flake:

 TestParallelLambdaCreation (4m58.42s)
      program.go:1950: sample: test-programs/parallel-lambdas
      program.go:1955: pulumi: /usr/local/bin/pulumi
      program.go:1090: acquired yarn install lock
      command.go:46: **** Invoke '/usr/local/bin/yarn install' in '/tmp/p-it-fv-az1215--parallel-l-5bfbab54-944644525'
      command.go:118: Wrote output to /tmp/p-it-fv-az1215--parallel-l-5bfbab54-944644525/command-output/yarn-install.20240702-170726.c6134.log
      program.go:1116: released yarn install lock
      program.go:1090: acquired yarn install lock
      command.go:46: **** Invoke '/usr/local/bin/yarn link @pulumi/aws' in '/tmp/p-it-fv-az1215--parallel-l-5bfbab54-944644525'
      command.go:118: Wrote output to /tmp/p-it-fv-az1215--parallel-l-5bfbab54-944644525/command-output/yarn-link.20240702-170727.78e87.log
      program.go:1116: released yarn install lock
      program.go:2100: projdir: /tmp/p-it-fv-az1215--parallel-l-5bfbab54-944644525
      program.go:1340: Initializing project (dir /tmp/p-it-fv-az1215--parallel-l-5bfbab54-944644525; stack p-it-fv-az1215--parallel-l-5bfbab54)
      command.go:46: **** Invoke '/usr/local/bin/pulumi login --cloud-url file:///tmp/TestParallelLambdaCreation2272984090/001' in '/tmp/p-it-fv-az1215--parallel-l-5bfbab54-944644525'
      command.go:118: Wrote output to /tmp/p-it-fv-az1215--parallel-l-5bfbab54-944644525/command-output/pulumi-login.20240702-170727.dc4a0.log
      command.go:46: **** Invoke '/usr/local/bin/pulumi stack init p-it-fv-az1215--parallel-l-5bfbab54' in '/tmp/p-it-fv-az1215--parallel-l-5bfbab54-944644525'
      command.go:118: Wrote output to /tmp/p-it-fv-az1215--parallel-l-5bfbab54-944644525/command-output/pulumi-stack-init.20240702-170727.850d2.log
      command.go:46: **** Invoke '/usr/local/bin/pulumi config set-all --plaintext aws:region=INVALID_REGION --plaintext aws:envRegion=us-west-2 --plaintext lambda:archivePath=/tmp/archive-723630976.zip' in '/tmp/p-it-fv-az1215--parallel-l-5bfbab54-944644525'
      command.go:121: Command completed without output
      program.go:1507: Performing primary preview and update
      command.go:46: **** Invoke '/usr/local/bin/pulumi preview --non-interactive --diff' in '/tmp/p-it-fv-az1215--parallel-l-5bfbab54-944644525'
      command.go:118: Wrote output to /tmp/p-it-fv-az1215--parallel-l-5bfbab54-944644525/command-output/pulumi-preview-initial.20240702-170736.65265.log
      command.go:46: **** Invoke '/usr/local/bin/pulumi up --non-interactive --yes --skip-preview --event-log /tmp/p-it-fv-az1215--parallel-l-5bfbab54-events.json' in '/tmp/p-it-fv-az1215--parallel-l-5bfbab54-944644525'
      command.go:118: Wrote output to /tmp/p-it-fv-az1215--parallel-l-5bfbab54-944644525/command-output/pulumi-update-initial.20240702-170846.57317.log
      program.go:1517: Roundtripping checkpoint via stack export and stack import
      command.go:46: **** Invoke '/usr/local/bin/pulumi stack export --file stack.json' in '/tmp/p-it-fv-az1215--parallel-l-5bfbab54-944644525'
      command.go:121: Command completed without output
      command.go:46: **** Invoke '/usr/local/bin/pulumi stack import --file stack.json' in '/tmp/p-it-fv-az1215--parallel-l-5bfbab54-944644525'
      command.go:118: Wrote output to /tmp/p-it-fv-az1215--parallel-l-5bfbab54-944644525/command-output/pulumi-stack-import.20240702-170847.451fb.log
      program.go:1529: Performing empty preview and update(no changes expected)
      command.go:46: **** Invoke '/usr/local/bin/pulumi preview --non-interactive --diff' in '/tmp/p-it-fv-az1215--parallel-l-5bfbab54-944644525'
      command.go:118: Wrote output to /tmp/p-it-fv-az1215--parallel-l-5bfbab54-944644525/command-output/pulumi-preview-empty.20240702-170851.5376a.log
      command.go:46: **** Invoke '/usr/local/bin/pulumi up --non-interactive --yes --skip-preview --event-log /tmp/p-it-fv-az1215--parallel-l-5bfbab54-events.json --expect-no-changes' in '/tmp/p-it-fv-az1215--parallel-l-5bfbab54-944644525'
      command.go:118: Wrote output to /tmp/p-it-fv-az1215--parallel-l-5bfbab54-944644525/command-output/pulumi-update-empty.20240702-170856.abaa3.log
      program.go:1465: Destroying stack
      command.go:46: **** Invoke '/usr/local/bin/pulumi destroy --non-interactive --yes --skip-preview' in '/tmp/p-it-fv-az1215--parallel-l-5bfbab54-944644525'
      provider_nodejs_test.go:212: Test timed out after 5m0s
  error: unable to open bucket file:///tmp/TestParallelLambdaCreation2272984090/001?no_tmp_dir=true: stat /tmp/TestParallelLambdaCreation2272984090/001: no such file or directory
  
  panic: Fail in goroutine after TestParallelLambdaCreation has completed
  
  goroutine 292 [running]:
  testing.(*common).Fail(0xc0002b0000)
  	/home/runner/go/pkg/mod/golang.org/[email protected]/src/testing/testing.go:952 +0xd4
  testing.(*common).Errorf(0xc0002b0000, {0x14ea7a8a?, 0x4118c5?}, {0xc002882560?, 0x122daa40?, 0x101?})
  	/home/runner/go/pkg/mod/golang.org/[email protected]/src/testing/testing.go:1075 +0x5e
  github.com/stretchr/testify/assert.Fail({0x16e9d4c0, 0xc0002b0000}, {0xc0002c4e80, 0x7f}, {0x0, 0x0, 0x0})
  	/home/runner/go/pkg/mod/github.com/stretchr/[email protected]/assert/assertions.go:363 +0x370
  github.com/stretchr/testify/assert.NoError({0x16e9d4c0, 0xc0002b0000}, {0x16e9d420, 0xc002882520}, {0x0, 0x0, 0x0})
  	/home/runner/go/pkg/mod/github.com/stretchr/[email protected]/assert/assertions.go:1545 +0x125
  github.com/pulumi/pulumi/pkg/v3/testing/integration.(*ProgramTester).TestLifeCycleInitAndDestroy.func1()
  	/home/runner/go/pkg/mod/github.com/pulumi/pulumi/pkg/[email protected]/testing/integration/program.go:1275 +0x45
  github.com/pulumi/pulumi/pkg/v3/testing/integration.(*ProgramTester).TestLifeCycleInitAndDestroy(0xc003e92180)
  	/home/runner/go/pkg/mod/github.com/pulumi/pulumi/pkg/[email protected]/testing/integration/program.go:1301 +0x49d
  github.com/pulumi/pulumi/pkg/v3/testing/integration.ProgramTest(0xc0002b0000, 0xc0006562c8)
  	/home/runner/go/pkg/mod/github.com/pulumi/pulumi/pkg/[email protected]/testing/integration/program.go:850 +0x31
  github.com/pulumi/pulumi-aws/provider/v6.TestParallelLambdaCreation.func1(0xc0002b0000)
  	/home/runner/work/pulumi-aws/pulumi-aws/provider/provider_nodejs_test.go:224 +0x268
  github.com/pulumi/pulumi-aws/provider/v6.maxDuration.func1()
  	/home/runner/work/pulumi-aws/pulumi-aws/provider/provider_test.go:212 +0x24
  created by github.com/pulumi/pulumi-aws/provider/v6.maxDuration in goroutine 291
  	/home/runner/work/pulumi-aws/pulumi-aws/provider/provider_test.go:211 +0xcc

@t0yv0 t0yv0 merged commit 55aac74 into master Jul 2, 2024
25 checks passed
@t0yv0 t0yv0 deleted the t0yv0/fix-cognito-regress-test branch July 2, 2024 18:41
@flostadler
Copy link
Contributor

@t0yv0 if we see this test flake more often we can increase the timeout. 5min might be a bit too aggressive

@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v6.43.0.

@mjeffryes mjeffryes added this to the 0.107 milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow failure: master
4 participants