Fix rds.Instance v5 to v6 migration #4027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabling PlanResourceChange=true on v6 of pulumi-aws provider regresses on replacing rds.Instance. It appears that the problem here is that the code has not been completely removing the deprecated "name" property from the old state. This is now fixed and covered by tests.
t0yv0
commented
Jun 5, 2024
| @@ -3094,6 +3094,7 @@ func ProviderFromMeta(metaInfo *tfbridge.MetadataInfo) *tfbridge.ProviderInfo { | |||
| }, | |||
| TransformFromState: func(ctx context.Context, state resource.PropertyMap) (resource.PropertyMap, error) { | |||
| if _, ok := state["dbName"]; ok { | |||
| delete(state, "name") | |||
There was a problem hiding this comment.
It seems that under PlanResourceChange, having "name" hanging around confuses the diff to think it's changing from "something" to "" and that should be a replacement.
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
t0yv0
deleted the
t0yv0/fix-rds-instance-migration-with-plan-resource-change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling PlanResourceChange=true on v6 of pulumi-aws provider regresses on replacing rds.Instance. It appears that the problem here is that the code has not been completely removing the deprecated "name" property from the old state. This is now fixed and covered by tests.