Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade terraform-provider-aws to v5.72.1 #4652

Closed
pulumi-bot opened this issue Oct 17, 2024 · 1 comment · Fixed by #4668
Closed

Upgrade terraform-provider-aws to v5.72.1 #4652

pulumi-bot opened this issue Oct 17, 2024 · 1 comment · Fixed by #4668
Assignees
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@pulumi-bot
Copy link
Contributor

pulumi-bot commented Oct 17, 2024

Release details: https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.72.1

Note

This issue was created automatically by the upgrade-provider tool and should be automatically closed by a subsequent upgrade pull request.

@pulumi-bot pulumi-bot added the kind/enhancement Improvements or new features label Oct 17, 2024
@t0yv0 t0yv0 self-assigned this Oct 25, 2024
t0yv0 added a commit that referenced this issue Oct 28, 2024
Upgrade upstream to v5.72.1

New resources:

iam/groupPolicyAttachmentsExclusive.GroupPolicyAttachmentsExclusive
iam/rolePolicyAttachmentsExclusive.RolePolicyAttachmentsExclusive
iam/userPolicyAttachmentsExclusive.UserPolicyAttachmentsExclusive

Fixes #4652
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Oct 28, 2024
@pulumi-bot
Copy link
Contributor Author

This issue has been addressed in PR #4668 and shipped in release v6.57.0.

danielrbradley added a commit to pulumi/upgrade-provider that referenced this issue Oct 31, 2024
Filtering via @me assumes that the user is always the same when creating
issues. This might not be true if a user runs this tool locally. This
also breaks when the author is an app such as github-actions as this
must be specified via the `--app` option instead of `--author`.

As an alternative approach, GitHub will index for search any word within
the issue body, even hidden within an HTML comment. We'll include the
word "pulumiupgradeproviderissue" in the HTML comment to allow listing
all upgrade issues easily via search. Once we've listed candidate
issues, we'll check client-side for an exact matching title.

Here's an example issue where I've manually added this hidden comment to
test searching:
- pulumi/pulumi-aws#4652

![Issue description
preview](https://github.com/user-attachments/assets/cc57dc0c-8bad-41d2-8c1b-b0ffb5f097ff)

We'll leave the existing "@me" based search in as a fallback until we
can be confident that these tokens will be present in relevant issues.

Resolves #280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants