-
Notifications
You must be signed in to change notification settings - Fork 157
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert upstream changes triggering LB panic (#3426)
This reverts the following upstream PRs: hashicorp/terraform-provider-aws#35671 hashicorp/terraform-provider-aws#35678 as a quick fix to mitigate #3421 until we root-cause it. Details on my findings so far: #3421 (comment) It looks to me like the issue originates somewhere in our handling of nulls/empty in the bridge, so seems unlikely to get fixed today. It also adds a test for LB listeners. I've verified that the test triggers the panic without the patches and that the patches resolve it.
- Loading branch information
1 parent
6cef7e7
commit 32a25bf
Showing
37 changed files
with
5,420 additions
and
918 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
/bin/ | ||
/node_modules/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
name: regress-3421 | ||
runtime: nodejs | ||
description: A minimal AWS TypeScript Pulumi program | ||
config: | ||
pulumi:tags: | ||
value: | ||
pulumi:template: aws-typescript |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
import * as aws from "@pulumi/aws"; | ||
|
||
const vpc = new aws.ec2.Vpc("main", { cidrBlock: "10.0.0.0/16" }); | ||
|
||
const currentRegion = aws.getRegion({}) | ||
const subnet = new aws.ec2.Subnet("main", { | ||
vpcId: vpc.id, | ||
cidrBlock: "10.0.12.0/24", | ||
availabilityZone: currentRegion.then(region => region.name + "a") | ||
}); | ||
|
||
const subnet2 = new aws.ec2.Subnet("subnet2", { | ||
vpcId: vpc.id, | ||
cidrBlock: "10.0.5.0/24", | ||
availabilityZone: currentRegion.then(region => region.name + "b") | ||
}); | ||
|
||
const secGroup = new aws.ec2.SecurityGroup("allowTls", { | ||
description: "Allow TLS inbound traffic and all outbound traffic", | ||
vpcId: vpc.id, | ||
tags: { | ||
Name: "allow_tls", | ||
}, | ||
}); | ||
|
||
const loadbalancer = new aws.lb.LoadBalancer("payload-lb", { | ||
loadBalancerType: "application", | ||
securityGroups: [secGroup.id], | ||
subnets: [subnet.id, subnet2.id], | ||
internal: true, | ||
}); | ||
|
||
const targetGroup = new aws.lb.TargetGroup("payload-tg", { | ||
port: 80, | ||
protocol: "HTTP", | ||
targetType: "ip", | ||
vpcId: vpc.id, | ||
}); | ||
|
||
new aws.lb.Listener("payload-lb-listner-http", { | ||
loadBalancerArn: loadbalancer.arn, | ||
port: 80, | ||
protocol: "HTTP", | ||
defaultActions: [ | ||
{ | ||
type: "forward", | ||
targetGroupArn: targetGroup.arn, | ||
}, | ||
], | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"name": "regress-3421", | ||
"main": "index.ts", | ||
"devDependencies": { | ||
"@types/node": "^18" | ||
}, | ||
"dependencies": { | ||
"@pulumi/pulumi": "^3.0.0", | ||
"@pulumi/aws": "^6.0.0", | ||
"@pulumi/awsx": "^2.0.2" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
{ | ||
"compilerOptions": { | ||
"strict": true, | ||
"outDir": "bin", | ||
"target": "es2016", | ||
"module": "commonjs", | ||
"moduleResolution": "node", | ||
"sourceMap": true, | ||
"experimentalDecorators": true, | ||
"pretty": true, | ||
"noFallthroughCasesInSwitch": true, | ||
"noImplicitReturns": true, | ||
"forceConsistentCasingInFileNames": true | ||
}, | ||
"files": [ | ||
"index.ts" | ||
] | ||
} |
Oops, something went wrong.