-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrating(eks): add example of migrating node groups with zero downtime #348
Conversation
e71096b
to
a3d4aab
Compare
a3d4aab
to
42ce0a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @metral
I left a few comments - nothing crazy - one thing to note - I think we need to link to the blog post so that users know how to run the example. It kinda breaks the other convention of the README having step by step instructions - but that would be duplicated effort :)
42ce0a0
to
d54dfa3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
You're right. This one is tricky given that the tutorial is the step-by-step instructions here per the unique scenario. I'll open a PR to link the tutorial steps here once the tutorial PR is merged. |
Sounds good to me! :) |
d54dfa3
to
79ea329
Compare
79ea329
to
5266c60
Compare
Adding a condensed example of the
pulumi/eks
e2e test.This example is related to the tutorial & blog post:
Also, refactor
assertHttpResultWithRetry()
to accept HTTP headers.