Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrating(eks): add example of migrating node groups with zero downtime #348

Merged
merged 2 commits into from
Jul 22, 2019

Conversation

metral
Copy link
Contributor

@metral metral commented Jul 18, 2019

Adding a condensed example of the pulumi/eks e2e test.

This example is related to the tutorial & blog post:

Also, refactor assertHttpResultWithRetry() to accept HTTP headers.

@metral metral force-pushed the metral/eks-migrate-nodegroups branch 2 times, most recently from e71096b to a3d4aab Compare July 18, 2019 04:37
@metral metral requested a review from lukehoban July 18, 2019 17:26
@metral metral force-pushed the metral/eks-migrate-nodegroups branch from a3d4aab to 42ce0a0 Compare July 19, 2019 18:42
@metral metral requested a review from stack72 July 19, 2019 18:43
Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @metral

I left a few comments - nothing crazy - one thing to note - I think we need to link to the blog post so that users know how to run the example. It kinda breaks the other convention of the README having step by step instructions - but that would be duplicated effort :)

@metral metral force-pushed the metral/eks-migrate-nodegroups branch from 42ce0a0 to d54dfa3 Compare July 22, 2019 17:23
Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metral
Copy link
Contributor Author

metral commented Jul 22, 2019

I think we need to link to the blog post so that users know how to run the example. It kinda breaks the other convention of the README having step by step instructions

You're right. This one is tricky given that the tutorial is the step-by-step instructions here per the unique scenario. I'll open a PR to link the tutorial steps here once the tutorial PR is merged.

@stack72
Copy link
Contributor

stack72 commented Jul 22, 2019

I think we need to link to the blog post so that users know how to run the example. It kinda breaks the other convention of the README having step by step instructions

You're right. This one is tricky given that the tutorial is the step-by-step instructions here per the unique scenario. I'll open a PR to link the tutorial steps here once the tutorial PR is merged.

Sounds good to me! :)

@metral metral force-pushed the metral/eks-migrate-nodegroups branch from d54dfa3 to 79ea329 Compare July 22, 2019 18:01
@metral metral force-pushed the metral/eks-migrate-nodegroups branch from 79ea329 to 5266c60 Compare July 22, 2019 18:06
@metral metral merged commit d1f81f2 into master Jul 22, 2019
@pulumi-bot pulumi-bot deleted the metral/eks-migrate-nodegroups branch July 22, 2019 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants