Specify pulumi access token per command run #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgavlin
reviewed
Mar 7, 2024
pgavlin
reviewed
Mar 7, 2024
pgavlin
reviewed
Mar 12, 2024
Comment on lines
+157
to
+168
| backendURL := esc.workspace.GetCurrentCloudURL(nil) | ||
|
|
||
| nAccount, err := esc.login.Login( | ||
| ctx, | ||
| backendURL, | ||
| false, | ||
| "esc", | ||
| "Pulumi ESC environments", | ||
| nil, | ||
| false, | ||
| display.Options{Color: esc.colors}, | ||
| ) |
There was a problem hiding this comment.
I think the only remaining question I have is what the experience is like if no access token is specified via PULUMI_ACCESS_TOKEN? If we fall through to the err != nil case below I think that we'll be regressing the UX, as the user will see could not determine current cloud instead of no credentials. Please run esc login to log in.
There was a problem hiding this comment.
It is the same experience you have with the pulumi cli where it asks you to authenticate
There was a problem hiding this comment.
what about in non-interactive scenarios?
There was a problem hiding this comment.
(try running with the output redirected, for example)
pgavlin
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #223
Add parity with the pulumi cli behavior supporting PULUMI_ACCESS_TOKEN and PULUMI_BACKEND_URL
I see the pulumi cli does an implicit login when it loads the backend
When ESC you have to explicitly login https://github.com/pulumi/esc/blob/4ce3ea5d470e475f1146e85cfcd7a75ea7516200/cmd/esc/cli/login.go#L82C29-L91
Added to that, ESC do not has parity on how the
backendURLis calculated, relying on thePULUMI_BACKEND_URL