cli: do not panic in env set foo bar ""
#110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After interpretation by the shell, `env set foo bar ""` passes an empty string as the value to set. The YAML parser treats the empty string as "no document" and doesn't return any content from Unmarshal. Work around this by treating "no document" as an empty string _literal_ (which is likely the intent). Fixes #109.
pgavlin
force-pushed
the
pgavlin/gh109
branch
from
fca7660 to
50bf763
Compare
cleverguy25
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After interpretation by the shell,
env set foo bar ""passes an empty string as the value to set. The YAML parser treats the empty string as "no document" and doesn't return any content from Unmarshal. Work around this by treating "no document" as an empty string literal (which is likely the intent).Fixes #109.