ignore github 403s #7616
ignore github 403s #7616
Conversation
|
Your site preview for commit 0e765e1 is ready! 🎉 http://pulumi-docs-origin-pr-7616-0e765e19.s3-website.us-west-2.amazonaws.com. |
![pulumi[bot]](https://avatars.githubusercontent.com/in/15540?s=60&v=4){kind=small}
There was a problem hiding this comment.
🍹 The Update (preview) for stack pulumi/www.pulumi.com/production was successful.
Resource Changes
Name Type Operation
~ cdn aws:cloudfront/distribution:Distribution update
* origin-bucket-policy aws:s3/bucketPolicy:BucketPolicy replaced
| @@ -306,6 +306,9 @@ function excludeAcceptable(links) { | |||
| // intelligently, but we can come back to that in a follow up. | |||
| .filter(b => !(b.reason === "HTTP_429" && b.destination.match(/github.com|npmjs.com/))) | |||
|
|
|||
| // Ignore GitHub 403s | |||
| .filter(b => !(b.reason === "HTTP_403" && b.destination.match(/github.com/))) | |||
There was a problem hiding this comment.
maybe we should ignore all 403s not just github ones 🤷🏻
There was a problem hiding this comment.
Before we just go ignoring, do we have some idea why these are returning 403 to begin with?
There was a problem hiding this comment.
i thought you wrote why in slack...
There was a problem hiding this comment.
There was a problem hiding this comment.
if you have another idea pls lets do that, the noise of the 403s is preventing us from seeing and fixing the 404s.
There was a problem hiding this comment.
That was one possibility, yeah, based on past experience. Has anyone looked more closely at these particular ones yet?
There was a problem hiding this comment.
Bit of Googling led me to this issue, which suggests adding an accept-encoding header can fix this, and local tests appear to confirm that me. So I'd probably explore adding that header first. A new line with an explanatory comment below this (similar) addition would probably be the way to do that: https://github.com/pulumi/docs/blob/master/scripts/link-checker/check-links.js#L52-L53 You can then run the checker locally against a page you know contains errant links like this:
$ ./scripts/link-checker/check-links.sh "page" "https://www.pulumi.com/blog/managing-github-webhooks-with-pulumi/"
|
Site previews for this pull request have been removed. ✨ |
website notifications is full of these
can we ignore them for now?
to clarify, there is nothing wrong with the github links, but the link checker is reporting them as 403s in the website notifications channel because of how the link checker was written, 20 or something a day