Upload unit test coverage for bridged providers by default #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is part of the following stack: Change managed by git-spice. |
blampe
commented
Dec 12, 2024
Comment on lines
-404
to
-432
| for _, j := range wf.Jobs { | ||
| for _, s := range j.Steps { | ||
| switch s.Name { | ||
| case "aws-actions/configure-aws-credentials": | ||
| config.ActionVersions.ConfigureAwsCredentials = s.Uses | ||
| case "google-github-actions/setup-gcloud": | ||
| config.ActionVersions.SetupGcloud = s.Uses | ||
| case "google-github-actions/auth": | ||
| config.ActionVersions.GoogleAuth = s.Uses | ||
| case "actions/checkout": | ||
| config.ActionVersions.Checkout = s.Uses | ||
| case "actions/download-artifact": | ||
| config.ActionVersions.DownloadArtifact = s.Uses | ||
| case "dorny/paths-filter": | ||
| config.ActionVersions.PathsFilter = s.Uses | ||
| case "thollander/actions-comment-pull-request": | ||
| config.ActionVersions.PrComment = s.Uses | ||
| case "actions/upload-artifact": | ||
| config.ActionVersions.UploadArtifact = s.Uses | ||
| case "pulumi/pulumi-upgrade-provider-action": | ||
| config.ActionVersions.UpgradeProviderAction = s.Uses | ||
| case "jlumbroso/free-disk-space": | ||
| config.ActionVersions.FreeDiskSpace = s.Uses | ||
| case "pulumi/provider-version-action": | ||
| config.ActionVersions.ProviderVersionAction = s.Uses | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Unused / leftover.
This is some hairy logic to preserve YAML comments. It would probably be simpler to forgo config.ActionVersions and just let Renovate manage the template files directly, but we can do that later.
blampe
force-pushed
the
blampe/codecov
branch
from
13c6acc to
1cc348e
Compare
t0yv0
reviewed
Dec 12, 2024
| @@ -239,7 +239,7 @@ test: | |||
| .PHONY: test | |||
|
|
|||
| test_provider: | |||
| cd provider && go test -v -short ./... -parallel $(TESTPARALLELISM) | |||
| cd provider && go test -v -short -coverprofile="coverage.txt" -coverpkg=./... ./... -parallel $(TESTPARALLELISM) | |||
There was a problem hiding this comment.
Do we need to spell out packages from ./upstream into coverpkgs or it's happening automatically? e.g. how are we covering the Terraform provider code itself.
There was a problem hiding this comment.
We can capture coverage for multiple modules like so:
-coverpkg="./...,github.com/hashicorp/terraform-provider-..."
This captures all of our local modules and any TF provider imports.
I don't know how this will render in Codecov (I'm guessing it won't show any TF information) but it can be helpful locally.
t0yv0
approved these changes
Dec 12, 2024
blampe
added a commit
to pulumi/pulumi-aws
that referenced
this pull request
Dec 12, 2024
This removes the `go_test_shim` job defined in `extraTests` by making it a normal provider unit test instead of something that needs to be run as part of upstream. We currently attempt to upload coverage as part of this test, but it [doesn't work](https://app.codecov.io/gh/pulumi/pulumi-aws). pulumi/ci-mgmt#1224 will start uploading unit test coverage by default.
blampe
force-pushed
the
blampe/codecov
branch
from
e922844 to
b284f90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn on codecov reporting for provider unit tests.