Pin dugite to 2.1.0
#7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeeDeeG
pushed a commit
that referenced
this pull request
Nov 14, 2023
--- ^ Original commit by confused-Techie on a PR branch. Committer notes (these notes are written by DeeDeeG): (cherry picked from commit dab6bd8) Cherry-picking #7 on a dedicated branch, since the `superstring` stuff is taking longer than expected, and this is a way to get just the `dugite` syncing/deduping landed at core repo faster, without waiting on the similarly motivated but separate `superstring` stuff I was doing. (Needs to be done on a separate branch to avoid either a really wacky commit history on `master` branch, with reverts and revert-reverts, or going with the "nuclear option" and force pushing to `master` branch after commits have been live there for multiple days.)
This was referenced Nov 14, 2023
|
Merging this, since we've been using this change in Pulsar core for a bit now. I think we can try bumping again to even newer Dugite, ahead of the upcoming Regular release. But it may as well be a follow-up PR, so merging this one as-is. Doesn't matter a ton if we're about to bump, but this belongs in the commit history of the default branch, IMO. Thanks again for working on all this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pins
dugiteto2.1.0. Really only because this is the same version pinned within thegithubpackage.Which is used by this dep, and we would like to sync these two deps perfectly to reduce the amount of times that
dugiteis installed into Pulsar