Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node API upgrade to V8 >= 8 #1

Merged
merged 6 commits into from
Sep 19, 2022
Merged

Node API upgrade to V8 >= 8 #1

merged 6 commits into from
Sep 19, 2022

Conversation

mauricioszabo
Copy link

No description provided.

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well all tests pass on this PR, and I'm assuming this is the plan, but as long as this eventually leads to a version bump with these changes I'm all for merging.

@mauricioszabo mauricioszabo merged commit eb0cc09 into master Sep 19, 2022
savetheclocktower added a commit to savetheclocktower/superstring that referenced this pull request Jul 3, 2024
…just to see if they're the cause of the editor test regressions in Pulsar.
savetheclocktower added a commit to savetheclocktower/superstring that referenced this pull request Jul 3, 2024
savetheclocktower added a commit to savetheclocktower/superstring that referenced this pull request Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants