Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme.md links to new site #83

Merged
merged 4 commits into from
Nov 4, 2022

Conversation

Daeraxa
Copy link
Member

@Daeraxa Daeraxa commented Oct 3, 2022

Links lead to the repo docs, now the new site is live we can redirect the buttons to the general docs section, the installation section (which is yet to be completed) and the the build instructions.

This will clash with #81 and #74 (if the latter is to be merged) but both are easy conflicts to resolve.

kaosine
kaosine previously requested changes Oct 4, 2022
@Daeraxa Daeraxa mentioned this pull request Nov 3, 2022
Copy link
Member

@Spiker985 Spiker985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added link to GitHub sunset blog post from #108

Co-authored-by: Spiker985 <[email protected]>
@Spiker985
Copy link
Member

This should also close #64 when merged

@Spiker985
Copy link
Member

@kaosine Since I don't have write access, I can't approve the PR to allow it to show it's merge status. You mind taking a look, and hopefully approving?

@Daeraxa
Copy link
Member Author

Daeraxa commented Nov 3, 2022

I sync'd the branch to include your commit from #81 so that shouldn't cause a merge issue now, it was still pending when I made this PR.

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I managed to miss it the first time, here's my approval.

Looks great, and I'll go ahead and remove @kaosine's changes since they seem to be addressed, and you are wanting to check the merge status.

@confused-Techie confused-Techie dismissed kaosine’s stale review November 3, 2022 04:27

Changes seem to be addressed. Contributor requesting merge status preview.

@confused-Techie
Copy link
Member

Alright, this PR has been active for over a month.

Since I've already approved it, and it is a non-code changing PR, meaning we only need one approval, I'll go ahead and merge.

Thanks for the contribution!

@confused-Techie confused-Techie merged commit c55b806 into pulsar-edit:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants