Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree-sitter rolling fixes for November #819

Conversation

savetheclocktower
Copy link
Contributor

It's technically still November. The streak continues!

@savetheclocktower savetheclocktower marked this pull request as draft November 29, 2023 21:02
…when some amount of text is deleted at the beginning of a file.

When this happens, the “affected range” of the buffer is an empty range from (0, 0) to (0, 0). Tree-sitter's `descendantsOfType` function incorrectly returns results when querying this specific range, so we'll sidestep this by explicitly returning early whenever the affected range is empty instead of trying to (re-)populate injections for a range that can't have any.
Treat `${}` identically to `$()`. Too trivial of a change for its own PR.
@savetheclocktower savetheclocktower marked this pull request as ready for review December 12, 2023 22:48
@savetheclocktower
Copy link
Contributor Author

Not sure why the find-and-replace tests are failing in CI, but I can at least verify that they all pass on my machine.

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always easy approve. Not the most familiar, but the changes here look valid, and seeing the issues they are solving seems good to me.

Just would ask you double check any related issues are properly linked to this PR, otherwise looks good to merge

@savetheclocktower
Copy link
Contributor Author

Yeah, surprisingly few of these fixes came from issues. Most were reported on Discord.

@savetheclocktower savetheclocktower merged commit 3d4440d into pulsar-edit:master Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emacs formatting comment breaks C file syntax highlighting
2 participants