-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tree-sitter rolling fixes for November #819
Tree-sitter rolling fixes for November #819
Conversation
* Destructured variable assignments are now scoped as `variable` * Namespaced decorators are now highlighted properly
…in addition to paragraphs.
…when some amount of text is deleted at the beginning of a file. When this happens, the “affected range” of the buffer is an empty range from (0, 0) to (0, 0). Tree-sitter's `descendantsOfType` function incorrectly returns results when querying this specific range, so we'll sidestep this by explicitly returning early whenever the affected range is empty instead of trying to (re-)populate injections for a range that can't have any.
Treat `${}` identically to `$()`. Too trivial of a change for its own PR.
Not sure why the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As always easy approve. Not the most familiar, but the changes here look valid, and seeing the issues they are solving seems good to me.
Just would ask you double check any related issues are properly linked to this PR, otherwise looks good to merge
Yeah, surprisingly few of these fixes came from issues. Most were reported on Discord. |
It's technically still November. The streak continues!